Subject: Re: [PATCH v3 05/15] bus: ts-nbus: use bitmap_get_value8()

From: Andy Shevchenko <[email-masked]>
Date: Tue, 11 Feb 2025 11:40:59 +0200

On Mon, Feb 10, 2025 at 04:33:31PM -0600, David Lechner wrote:
> Use bitmap_get_value8() instead of accessing the bitmap directly.
> 
> Accessing the bitmap directly is not considered good practice. We now
> have a helper function that can be used instead, so let's use it.

Thank you, LGTM (one minor thing you may address,
or keep it as in the current variant of the patch),

Reviewed-by: Andy Shevchenko <[email-masked]>

...

> +#include <linux/bitmap.h>
>  #include <linux/bitops.h>

bitmap.h implies bitops.h

-- 
With Best Regards,
Andy Shevchenko