From: "Russell King (Oracle)" <linux@armlinux•org.uk>
To: Inochi Amaoto <inochiama@gmail•com>
Cc: "Andrew Lunn" <andrew+netdev@lunn•ch>,
"David S. Miller" <davem@davemloft•net>,
"Eric Dumazet" <edumazet@google•com>,
"Jakub Kicinski" <kuba@kernel•org>,
"Paolo Abeni" <pabeni@redhat•com>,
"Rob Herring" <robh@kernel•org>,
"Krzysztof Kozlowski" <krzk+dt@kernel•org>,
"Conor Dooley" <conor+dt@kernel•org>,
"Chen Wang" <unicorn_wang@outlook•com>,
"Maxime Coquelin" <mcoquelin.stm32@gmail•com>,
"Alexandre Torgue" <alexandre.torgue@foss•st.com>,
"Richard Cochran" <richardcochran@gmail•com>,
"Paul Walmsley" <paul.walmsley@sifive•com>,
"Palmer Dabbelt" <palmer@dabbelt•com>,
"Albert Ou" <aou@eecs•berkeley.edu>,
"Jan Petrous (OSS)" <jan.petrous@oss•nxp.com>,
"Hariprasad Kelam" <hkelam@marvell•com>,
"Clément Léger" <clement.leger@bootlin•com>,
"Jisheng Zhang" <jszhang@kernel•org>,
"Emil Renner Berthing" <emil.renner.berthing@canonical•com>,
"Drew Fustini" <dfustini@tenstorrent•com>,
"Furong Xu" <0x1207@gmail•com>,
"Bartosz Golaszewski" <bartosz.golaszewski@linaro•org>,
"Joe Hattori" <joe@pf•is.s.u-tokyo.ac.jp>,
"Serge Semin" <fancer.lancer@gmail•com>,
"Lothar Rubusch" <l.rubusch@gmail•com>,
"Giuseppe Cavallaro" <peppe.cavallaro@st•com>,
"Jose Abreu" <joabreu@synopsys•com>,
netdev@vger•kernel.org, devicetree@vger•kernel.org,
linux-kernel@vger•kernel.org, sophgo@lists•linux.dev,
linux-stm32@st-md-mailman•stormreply.com,
linux-arm-kernel@lists•infradead.org,
linux-riscv@lists•infradead.org, "Yixun Lan" <dlan@gentoo•org>,
"Longbin Li" <looong.bin@gmail•com>
Subject: Re: [PATCH net-next v5 3/3] net: stmmac: Add glue layer for Sophgo SG2044 SoC
Date: Sun, 16 Feb 2025 15:47:18 +0000 [thread overview]
Message-ID: <Z7IIht2Q-iXEFw7x@shell.armlinux.org.uk> (raw)
In-Reply-To: <20250216123953.1252523-4-inochiama@gmail.com>
On Sun, Feb 16, 2025 at 08:39:51PM +0800, Inochi Amaoto wrote:
> +static void sophgo_dwmac_fix_mac_speed(void *priv, unsigned int speed, unsigned int mode)
> +{
> + struct sophgo_dwmac *dwmac = priv;
> + long rate;
> + int ret;
> +
> + rate = rgmii_clock(speed);
> + if (rate < 0) {
> + dev_err(dwmac->dev, "invalid speed %u\n", speed);
> + return;
> + }
> +
> + ret = clk_set_rate(dwmac->clk_tx, rate);
> + if (ret)
> + dev_err(dwmac->dev, "failed to set tx rate %ld: %pe\n",
> + rate, ERR_PTR(ret));
> +}
There are a bunch of other platform support in stmmac that are doing
the same:
dwmac-s32.c is virtually identical
dwmac-imx.c does the same, although has some pre-conditions
dwmac-dwc-qos-eth.c is virually identical but the two steps are split
across a bunch of register writes
dwmac-starfive.c looks the same
dwmac-rk.c also
dwmac-intel-plat.c also
So, I wonder whether either this should be a helper, or whether core
code should be doing this. Maybe something to look at as a part of
this patch submission?
We really need to stop writing the same code in different ways and
think more about how to reuse the code that's already present!
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2025-02-16 15:48 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-16 12:39 [PATCH net-next v5 0/3] riscv: sophgo: Add ethernet support for SG2044 Inochi Amaoto
2025-02-16 12:39 ` [PATCH net-next v5 1/3] dt-bindings: net: Add support for Sophgo SG2044 dwmac Inochi Amaoto
2025-02-16 12:39 ` [PATCH net-next v5 2/3] net: stmmac: platform: Add snps,dwmac-5.30a IP compatible string Inochi Amaoto
2025-02-16 16:59 ` Andrew Lunn
2025-02-17 0:55 ` Inochi Amaoto
2025-02-16 12:39 ` [PATCH net-next v5 3/3] net: stmmac: Add glue layer for Sophgo SG2044 SoC Inochi Amaoto
2025-02-16 15:47 ` Russell King (Oracle) [this message]
2025-02-16 17:07 ` Andrew Lunn
2025-02-17 4:16 ` Inochi Amaoto
2025-02-17 13:25 ` Andrew Lunn
2025-02-17 14:10 ` Russell King (Oracle)
2025-02-17 22:50 ` Inochi Amaoto
2025-02-17 23:21 ` Russell King (Oracle)
2025-02-18 1:01 ` Inochi Amaoto
2025-02-18 10:40 ` Russell King (Oracle)
2025-02-18 11:34 ` Inochi Amaoto
2025-02-18 13:03 ` Inochi Amaoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z7IIht2Q-iXEFw7x@shell.armlinux.org.uk \
--to=linux@armlinux$(echo .)org.uk \
--cc=0x1207@gmail$(echo .)com \
--cc=alexandre.torgue@foss$(echo .)st.com \
--cc=andrew+netdev@lunn$(echo .)ch \
--cc=aou@eecs$(echo .)berkeley.edu \
--cc=bartosz.golaszewski@linaro$(echo .)org \
--cc=clement.leger@bootlin$(echo .)com \
--cc=conor+dt@kernel$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=dfustini@tenstorrent$(echo .)com \
--cc=dlan@gentoo$(echo .)org \
--cc=edumazet@google$(echo .)com \
--cc=emil.renner.berthing@canonical$(echo .)com \
--cc=fancer.lancer@gmail$(echo .)com \
--cc=hkelam@marvell$(echo .)com \
--cc=inochiama@gmail$(echo .)com \
--cc=jan.petrous@oss$(echo .)nxp.com \
--cc=joabreu@synopsys$(echo .)com \
--cc=joe@pf$(echo .)is.s.u-tokyo.ac.jp \
--cc=jszhang@kernel$(echo .)org \
--cc=krzk+dt@kernel$(echo .)org \
--cc=kuba@kernel$(echo .)org \
--cc=l.rubusch@gmail$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-riscv@lists$(echo .)infradead.org \
--cc=linux-stm32@st-md-mailman$(echo .)stormreply.com \
--cc=looong.bin@gmail$(echo .)com \
--cc=mcoquelin.stm32@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=palmer@dabbelt$(echo .)com \
--cc=paul.walmsley@sifive$(echo .)com \
--cc=peppe.cavallaro@st$(echo .)com \
--cc=richardcochran@gmail$(echo .)com \
--cc=robh@kernel$(echo .)org \
--cc=sophgo@lists$(echo .)linux.dev \
--cc=unicorn_wang@outlook$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox