From: Stanislav Fomichev <stfomichev@gmail•com>
To: Mina Almasry <almasrymina@google•com>
Cc: netdev@vger•kernel.org, linux-kernel@vger•kernel.org,
linux-doc@vger•kernel.org, virtualization@lists•linux.dev,
kvm@vger•kernel.org, linux-kselftest@vger•kernel.org,
"David S. Miller" <davem@davemloft•net>,
"Eric Dumazet" <edumazet@google•com>,
"Jakub Kicinski" <kuba@kernel•org>,
"Paolo Abeni" <pabeni@redhat•com>,
"Simon Horman" <horms@kernel•org>,
"Donald Hunter" <donald.hunter@gmail•com>,
"Jonathan Corbet" <corbet@lwn•net>,
"Andrew Lunn" <andrew+netdev@lunn•ch>,
"Jeroen de Borst" <jeroendb@google•com>,
"Praveen Kaligineedi" <pkaligineedi@google•com>,
"Shailend Chand" <shailend@google•com>,
"Kuniyuki Iwashima" <kuniyu@amazon•com>,
"Willem de Bruijn" <willemb@google•com>,
"David Ahern" <dsahern@kernel•org>,
"Neal Cardwell" <ncardwell@google•com>,
"Michael S. Tsirkin" <mst@redhat•com>,
"Jason Wang" <jasowang@redhat•com>,
"Xuan Zhuo" <xuanzhuo@linux•alibaba.com>,
"Eugenio Pérez" <eperezma@redhat•com>,
"Stefan Hajnoczi" <stefanha@redhat•com>,
"Stefano Garzarella" <sgarzare@redhat•com>,
"Shuah Khan" <shuah@kernel•org>,
sdf@fomichev•me, asml.silence@gmail•com, dw@davidwei•uk,
"Jamal Hadi Salim" <jhs@mojatatu•com>,
"Victor Nogueira" <victor@mojatatu•com>,
"Pedro Tammela" <pctammela@mojatatu•com>,
"Samiullah Khawaja" <skhawaja@google•com>
Subject: Re: [PATCH net-next v4 9/9] selftests: ncdevmem: Implement devmem TCP TX
Date: Thu, 20 Feb 2025 11:09:55 -0800 [thread overview]
Message-ID: <Z7d-A7yhzH1t8D_3@mini-arch> (raw)
In-Reply-To: <20250220020914.895431-10-almasrymina@google.com>
On 02/20, Mina Almasry wrote:
> Add support for devmem TX in ncdevmem.
>
> This is a combination of the ncdevmem from the devmem TCP series RFCv1
> which included the TX path, and work by Stan to include the netlink API
> and refactored on top of his generic memory_provider support.
>
> Signed-off-by: Mina Almasry <almasrymina@google•com>
> Signed-off-by: Stanislav Fomichev <sdf@fomichev•me>
>
> ---
>
> v4:
> - Add TX test to devmem.py (Paolo).
>
> v3:
> - Update ncdevmem docs to run validation with RX-only and RX-with-TX.
> - Fix build warnings (Stan).
> - Make the validation expect new lines in the pattern so we can have the
> TX path behave like netcat (Stan).
> - Change ret to errno in error() calls (Stan).
> - Handle the case where client_ip is not provided (Stan).
> - Don't assume mid is <= 2000 (Stan).
>
> v2:
> - make errors a static variable so that we catch instances where there
> are less than 20 errors across different buffers.
> - Fix the issue where the seed is reset to 0 instead of its starting
> value 1.
> - Use 1000ULL instead of 1000 to guard against overflow (Willem).
> - Do not set POLLERR (Willem).
> - Update the test to use the new interface where iov_base is the
> dmabuf_offset.
> - Update the test to send 2 iov instead of 1, so we get some test
> coverage over sending multiple iovs at once.
> - Print the ifindex the test is using, useful for debugging issues where
> maybe the test may fail because the ifindex of the socket is different
> from the dmabuf binding.
>
> ---
> .../selftests/drivers/net/hw/devmem.py | 28 +-
> .../selftests/drivers/net/hw/ncdevmem.c | 300 +++++++++++++++++-
> 2 files changed, 312 insertions(+), 16 deletions(-)
>
> diff --git a/tools/testing/selftests/drivers/net/hw/devmem.py b/tools/testing/selftests/drivers/net/hw/devmem.py
> index 1223f0f5c10c..3d4f7fc5e63f 100755
> --- a/tools/testing/selftests/drivers/net/hw/devmem.py
> +++ b/tools/testing/selftests/drivers/net/hw/devmem.py
> @@ -1,6 +1,7 @@
> #!/usr/bin/env python3
> # SPDX-License-Identifier: GPL-2.0
>
> +from os import path
> from lib.py import ksft_run, ksft_exit
> from lib.py import ksft_eq, KsftSkipEx
> from lib.py import NetDrvEpEnv
> @@ -10,8 +11,7 @@ from lib.py import ksft_disruptive
>
> def require_devmem(cfg):
> if not hasattr(cfg, "_devmem_probed"):
> - port = rand_port()
> - probe_command = f"./ncdevmem -f {cfg.ifname}"
> + probe_command = f"{cfg.bin_local} -f {cfg.ifname}"
> cfg._devmem_supported = cmd(probe_command, fail=False, shell=True).ret == 0
> cfg._devmem_probed = True
>
> @@ -25,18 +25,36 @@ def check_rx(cfg) -> None:
> require_devmem(cfg)
>
> port = rand_port()
> - listen_cmd = f"./ncdevmem -l -f {cfg.ifname} -s {cfg.v6} -p {port}"
> + listen_cmd = f"{cfg.bin_local} -l -f {cfg.ifname} -s {cfg.v6} -p {port}"
Commit de94e8697405 ("selftests: drv-net: store addresses in dict indexed by
ipver") just went it, so v6 needs to be addr_v['6'] and remote_v6 needs
to be remote_addr_v['6'].
>
> with bkg(listen_cmd) as socat:
> wait_port_listen(port)
> - cmd(f"echo -e \"hello\\nworld\"| socat -u - TCP6:[{cfg.v6}]:{port}", host=cfg.remote, shell=True)
> + cmd(f"echo -e \"hello\\nworld\"| socat -u - TCP6:{cfg.v6}:{port},bind={cfg.remote_v6}:{port}", host=cfg.remote, shell=True)
> +
[..]
> + ksft_eq(ncdevmem.stdout.strip(), "hello\nworld")
s/ncdevmem/socat/ (or rename socat in the with block above)
> +@ksft_disruptive
> +def check_tx(cfg) -> None:
[..]
> + cfg.require_v6()
This is also now require_ipver("6") I think..
Gonna try to run the selftest and see if anything else pops up...
next prev parent reply other threads:[~2025-02-20 19:09 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-20 2:09 [PATCH net-next v4 0/9] Device memory TCP TX Mina Almasry
2025-02-20 2:09 ` [PATCH net-next v4 1/9] net: add get_netmem/put_netmem support Mina Almasry
2025-02-20 19:34 ` Stanislav Fomichev
2025-02-20 2:09 ` [PATCH net-next v4 2/9] net: devmem: TCP tx netlink api Mina Almasry
2025-02-20 2:09 ` [PATCH net-next v4 3/9] net: devmem: Implement TX path Mina Almasry
2025-02-20 21:00 ` Stanislav Fomichev
2025-02-20 2:09 ` [PATCH net-next v4 4/9] net: devmem: make dmabuf unbinding scheduled work Mina Almasry
2025-02-20 21:00 ` Stanislav Fomichev
2025-02-20 2:09 ` [PATCH net-next v4 5/9] net: add devmem TCP TX documentation Mina Almasry
2025-02-20 8:13 ` Bagas Sanjaya
2025-02-20 21:04 ` Stanislav Fomichev
2025-02-20 2:09 ` [PATCH net-next v4 6/9] net: enable driver support for netmem TX Mina Almasry
2025-02-20 19:13 ` Stanislav Fomichev
2025-02-22 0:11 ` Mina Almasry
2025-02-22 0:35 ` Stanislav Fomichev
2025-02-20 2:09 ` [PATCH net-next v4 7/9] gve: add netmem TX support to GVE DQO-RDA mode Mina Almasry
2025-02-20 2:09 ` [PATCH net-next v4 8/9] net: check for driver support in netmem TX Mina Almasry
2025-02-20 21:05 ` Stanislav Fomichev
2025-02-20 2:09 ` [PATCH net-next v4 9/9] selftests: ncdevmem: Implement devmem TCP TX Mina Almasry
2025-02-20 19:09 ` Stanislav Fomichev [this message]
2025-02-20 20:01 ` Stanislav Fomichev
2025-02-22 0:08 ` Mina Almasry
2025-02-22 0:20 ` Stanislav Fomichev
2025-02-22 0:24 ` Mina Almasry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z7d-A7yhzH1t8D_3@mini-arch \
--to=stfomichev@gmail$(echo .)com \
--cc=almasrymina@google$(echo .)com \
--cc=andrew+netdev@lunn$(echo .)ch \
--cc=asml.silence@gmail$(echo .)com \
--cc=corbet@lwn$(echo .)net \
--cc=davem@davemloft$(echo .)net \
--cc=donald.hunter@gmail$(echo .)com \
--cc=dsahern@kernel$(echo .)org \
--cc=dw@davidwei$(echo .)uk \
--cc=edumazet@google$(echo .)com \
--cc=eperezma@redhat$(echo .)com \
--cc=horms@kernel$(echo .)org \
--cc=jasowang@redhat$(echo .)com \
--cc=jeroendb@google$(echo .)com \
--cc=jhs@mojatatu$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=kuniyu@amazon$(echo .)com \
--cc=kvm@vger$(echo .)kernel.org \
--cc=linux-doc@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-kselftest@vger$(echo .)kernel.org \
--cc=mst@redhat$(echo .)com \
--cc=ncardwell@google$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=pctammela@mojatatu$(echo .)com \
--cc=pkaligineedi@google$(echo .)com \
--cc=sdf@fomichev$(echo .)me \
--cc=sgarzare@redhat$(echo .)com \
--cc=shailend@google$(echo .)com \
--cc=shuah@kernel$(echo .)org \
--cc=skhawaja@google$(echo .)com \
--cc=stefanha@redhat$(echo .)com \
--cc=victor@mojatatu$(echo .)com \
--cc=virtualization@lists$(echo .)linux.dev \
--cc=willemb@google$(echo .)com \
--cc=xuanzhuo@linux$(echo .)alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox