From: Hangbin Liu <liuhangbin@gmail•com>
To: Cosmin Ratiu <cratiu@nvidia•com>
Cc: "kuba@kernel•org" <kuba@kernel•org>,
"razor@blackwall•org" <razor@blackwall•org>,
"andrew+netdev@lunn•ch" <andrew+netdev@lunn•ch>,
"jarod@redhat•com" <jarod@redhat•com>,
"davem@davemloft•net" <davem@davemloft•net>,
Tariq Toukan <tariqt@nvidia•com>, Petr Machata <petrm@nvidia•com>,
"linux-kernel@vger•kernel.org" <linux-kernel@vger•kernel.org>,
"shuah@kernel•org" <shuah@kernel•org>,
"steffen.klassert@secunet•com" <steffen.klassert@secunet•com>,
"jv@jvosburgh•net" <jv@jvosburgh•net>,
"pabeni@redhat•com" <pabeni@redhat•com>,
"horms@kernel•org" <horms@kernel•org>,
"edumazet@google•com" <edumazet@google•com>,
"netdev@vger•kernel.org" <netdev@vger•kernel.org>,
"linux-kselftest@vger•kernel.org"
<linux-kselftest@vger•kernel.org>,
Jianbo Liu <jianbol@nvidia•com>
Subject: Re: [PATCHv5 net 1/3] bonding: fix calling sleeping function in spin lock and some race conditions
Date: Wed, 12 Mar 2025 01:04:14 +0000 [thread overview]
Message-ID: <Z9Ddjgrxv5wQM-wV@fedora> (raw)
In-Reply-To: <f9b85a06113e2c9a7a91f3486efc06edbce4e461.camel@nvidia.com>
On Tue, Mar 11, 2025 at 09:08:49PM +0000, Cosmin Ratiu wrote:
> On Fri, 2025-03-07 at 09:03 -0800, Jakub Kicinski wrote:
> > On Fri, 7 Mar 2025 09:42:49 +0200 Nikolay Aleksandrov wrote:
> > > TBH, keeping buggy code with a comment doesn't sound good to me.
> > > I'd rather remove this
> > > support than tell people "good luck, it might crash". It's better
> > > to be safe until a
> > > correct design is in place which takes care of these issues.
> >
> > That's my feeling too, FWIW. I think we knew about this issue
> > for a while now, the longer we wait the more users we may disrupt
> > with the revert.
>
> These are preexisting races between the bond link failover and the user
> removing the xfrm states. Unless the user wants to intentionally
> trigger these bugs, chances are nobody has ever encountered them in the
> wild in normal operation. In steady state, bond link failover works,
> and adding/removing states works. It's the combination of the two
> control plane events that may have a chance to double free or leak
> states.
>
> I would not pull everything out just yet.
>
> Today, I managed to find a solution for these races (I think), based on
> a patch series I am preparing against ipsec-next with other changes
> related to real_dev.
>
> Hangbin, do you mind if I take over fixing the locking issue as part of
> my series? I plan to send it upstream the following days.
No, I don't mind. Please go ahead to fixing the locking issue. And thanks
a lot for your reviewing.
Regards
Hangbin
next prev parent reply other threads:[~2025-03-12 1:04 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-07 3:19 [PATCHv5 net 0/3] bond: fix xfrm offload issues Hangbin Liu
2025-03-07 3:19 ` [PATCHv5 net 1/3] bonding: fix calling sleeping function in spin lock and some race conditions Hangbin Liu
2025-03-07 7:42 ` Nikolay Aleksandrov
2025-03-07 8:11 ` Hangbin Liu
2025-03-07 8:33 ` Nikolay Aleksandrov
2025-03-07 10:31 ` Hangbin Liu
2025-03-07 17:03 ` Jakub Kicinski
2025-03-10 7:53 ` Hangbin Liu
2025-03-11 21:08 ` Cosmin Ratiu
2025-03-12 1:04 ` Hangbin Liu [this message]
2025-03-08 8:54 ` Simon Horman
2025-03-10 7:22 ` Hangbin Liu
2025-03-07 3:19 ` [PATCHv5 net 2/3] bonding: fix xfrm offload feature setup on active-backup mode Hangbin Liu
2025-03-07 3:19 ` [PATCHv5 net 3/3] selftests: bonding: add ipsec offload test Hangbin Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z9Ddjgrxv5wQM-wV@fedora \
--to=liuhangbin@gmail$(echo .)com \
--cc=andrew+netdev@lunn$(echo .)ch \
--cc=cratiu@nvidia$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=horms@kernel$(echo .)org \
--cc=jarod@redhat$(echo .)com \
--cc=jianbol@nvidia$(echo .)com \
--cc=jv@jvosburgh$(echo .)net \
--cc=kuba@kernel$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-kselftest@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=petrm@nvidia$(echo .)com \
--cc=razor@blackwall$(echo .)org \
--cc=shuah@kernel$(echo .)org \
--cc=steffen.klassert@secunet$(echo .)com \
--cc=tariqt@nvidia$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox