From: Ido Schimmel <idosch@idosch•org>
To: Daniel Lezcano <daniel.lezcano@linaro•org>
Cc: rafael@kernel•org, linux-kernel@vger•kernel.org,
linux-pm@vger•kernel.org, rui.zhang@intel•com,
"Raju Rangoju" <rajur@chelsio•com>,
"David S. Miller" <davem@davemloft•net>,
"Eric Dumazet" <edumazet@google•com>,
"Jakub Kicinski" <kuba@kernel•org>,
"Paolo Abeni" <pabeni@redhat•com>,
"Peter Kaestle" <peter@piie•net>,
"Hans de Goede" <hdegoede@redhat•com>,
"Mark Gross" <markgross@kernel•org>,
"Miquel Raynal" <miquel.raynal@bootlin•com>,
"Amit Kucheria" <amitk@kernel•org>,
"Nicolas Saenz Julienne" <nsaenz@kernel•org>,
"Broadcom Kernel Team" <bcm-kernel-feedback-list@broadcom•com>,
"Florian Fainelli" <f.fainelli@gmail•com>,
"Ray Jui" <rjui@broadcom•com>,
"Scott Branden" <sbranden@broadcom•com>,
"Support Opensource" <support.opensource@diasemi•com>,
"Lukasz Luba" <lukasz.luba@arm•com>,
"Shawn Guo" <shawnguo@kernel•org>,
"Sascha Hauer" <s.hauer@pengutronix•de>,
"Pengutronix Kernel Team" <kernel@pengutronix•de>,
"Fabio Estevam" <festevam@gmail•com>,
"NXP Linux Team" <linux-imx@nxp•com>,
"Thara Gopinath" <thara.gopinath@linaro•org>,
"Andy Gross" <agross@kernel•org>,
"Bjorn Andersson" <bjorn.andersson@linaro•org>,
"Niklas Söderlund" <niklas.soderlund@ragnatech•se>,
"Bartlomiej Zolnierkiewicz" <bzolnier@gmail•com>,
"Krzysztof Kozlowski" <krzysztof.kozlowski@linaro•org>,
"Alim Akhtar" <alim.akhtar@samsung•com>,
"Thierry Reding" <thierry.reding@gmail•com>,
"Jonathan Hunter" <jonathanh@nvidia•com>,
"Eduardo Valentin" <edubezval@gmail•com>,
Keerthy <j-keerthy@ti•com>,
"Kunihiko Hayashi" <hayashi.kunihiko@socionext•com>,
"Masami Hiramatsu" <mhiramat@kernel•org>,
"Antoine Tenart" <atenart@kernel•org>,
"Srinivas Pandruvada" <srinivas.pandruvada@linux•intel.com>,
"Dmitry Osipenko" <digetx@gmail•com>,
netdev@vger•kernel.org, platform-driver-x86@vger•kernel.org,
linux-rpi-kernel@lists•infradead.org,
linux-arm-kernel@lists•infradead.org,
linux-arm-msm@vger•kernel.org, linux-renesas-soc@vger•kernel.org,
linux-samsung-soc@vger•kernel.org, linux-tegra@vger•kernel.org,
linux-omap@vger•kernel.org,
"Rafael J . Wysocki" <rafael.j.wysocki@intel•com>,
danieller@nvidia•com, vadimp@nvidia•com, petrm@nvidia•com
Subject: Re: [PATCH v8 01/29] thermal/core: Add a generic thermal_zone_get_trip() function
Date: Mon, 13 Mar 2023 14:12:44 +0200 [thread overview]
Message-ID: <ZA8TPDpEVanOpjEp@shredder> (raw)
In-Reply-To: <f78e6b70-a963-c0ca-a4b2-0d4c6aeef1fb@linaro.org>
On Mon, Mar 13, 2023 at 11:45:41AM +0100, Daniel Lezcano wrote:
> Thanks for reporting this, I think the fix you are proposing is correct
> regarding the previous behavior.
>
> However, I disagree with the commit 81ad4276b505, because it defines the
> zero as an invalid trip point. But some platforms have warming devices, when
> the temperature is too cold, eg 0°C, we enable the warming device in order
> to stay in the functioning temperature range.
>
> Other devices can do the same with negative temperature values.
>
> This feature is not yet upstream and the rework of the trip point should
> allow proper handling of cold trip points.
>
> If you can send the change to fix the regression that would be great.
Thanks for the reply. Will send you the fix later this week. I want to
test it across all of our systems.
>
> But keep in mind, the driver is assuming an internal thermal framework
> behavior. The trips_disabled is only to overcome a trip point description
> bug and you should not rely on it as well as not changing the trip points on
> the fly after they are registered.
>
> Actually, the mlxsw driver should just build a valid array of trip points
> without 0°C trip point and pass it to
> thermal_zone_device_register_with_trips(). That would be a proper change
> without relying on a side effect of the thermal trip bug 0°C workaround.
Understood. Will check with Vadim what we can do in order not to rely on
this behavior.
next prev parent reply other threads:[~2023-03-13 12:13 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20221003092704eucas1p2875c1f996dfd60a58f06cf986e02e8eb@eucas1p2.samsung.com>
2022-10-03 9:25 ` [PATCH v8 00/29] Rework the trip points creation Daniel Lezcano
2022-10-03 9:25 ` [PATCH v8 01/29] thermal/core: Add a generic thermal_zone_get_trip() function Daniel Lezcano
2023-03-12 12:14 ` Ido Schimmel
2023-03-13 10:45 ` Daniel Lezcano
2023-03-13 12:12 ` Ido Schimmel [this message]
2022-10-03 9:25 ` [PATCH v8 02/29] thermal/sysfs: Always expose hysteresis attributes Daniel Lezcano
2022-10-03 9:25 ` [PATCH v8 03/29] thermal/core: Add a generic thermal_zone_set_trip() function Daniel Lezcano
2022-10-03 11:56 ` Rafael J. Wysocki
2022-10-03 9:25 ` [PATCH v8 04/29] thermal/core/governors: Use thermal_zone_get_trip() instead of ops functions Daniel Lezcano
2022-10-03 9:25 ` [PATCH v8 05/29] thermal/of: Use generic thermal_zone_get_trip() function Daniel Lezcano
2022-10-03 9:25 ` [PATCH v8 06/29] thermal/of: Remove unused functions Daniel Lezcano
2022-10-03 9:25 ` [PATCH v8 07/29] thermal/drivers/exynos: Use generic thermal_zone_get_trip() function Daniel Lezcano
2022-10-03 9:25 ` [PATCH v8 08/29] thermal/drivers/exynos: of_thermal_get_ntrips() Daniel Lezcano
2022-10-03 9:25 ` [PATCH v8 09/29] thermal/drivers/exynos: Replace of_thermal_is_trip_valid() by thermal_zone_get_trip() Daniel Lezcano
2022-10-03 9:25 ` [PATCH v8 10/29] thermal/drivers/tegra: Use generic thermal_zone_get_trip() function Daniel Lezcano
2022-10-03 9:25 ` [PATCH v8 11/29] thermal/drivers/uniphier: " Daniel Lezcano
2022-10-03 9:25 ` [PATCH v8 12/29] thermal/drivers/hisi: " Daniel Lezcano
2022-10-03 9:25 ` [PATCH v8 13/29] thermal/drivers/qcom: " Daniel Lezcano
2022-10-03 9:25 ` [PATCH v8 14/29] thermal/drivers/armada: " Daniel Lezcano
2022-10-03 9:25 ` [PATCH v8 15/29] thermal/drivers/rcar_gen3: Use the generic function to get the number of trips Daniel Lezcano
2022-10-03 9:25 ` [PATCH v8 16/29] thermal/of: Remove of_thermal_get_ntrips() Daniel Lezcano
2022-10-03 9:25 ` [PATCH v8 17/29] thermal/of: Remove of_thermal_is_trip_valid() Daniel Lezcano
2022-10-03 9:25 ` [PATCH v8 18/29] thermal/of: Remove of_thermal_set_trip_hyst() Daniel Lezcano
2022-10-03 9:25 ` [PATCH v8 19/29] thermal/of: Remove of_thermal_get_crit_temp() Daniel Lezcano
2022-10-03 9:25 ` [PATCH v8 20/29] thermal/drivers/st: Use generic trip points Daniel Lezcano
2022-10-03 9:25 ` [PATCH v8 21/29] thermal/drivers/imx: Use generic thermal_zone_get_trip() function Daniel Lezcano
2022-10-03 9:25 ` [PATCH v8 22/29] thermal/drivers/rcar: " Daniel Lezcano
2022-10-03 9:25 ` [PATCH v8 23/29] thermal/drivers/broadcom: " Daniel Lezcano
2022-10-03 9:25 ` [PATCH v8 24/29] thermal/drivers/da9062: " Daniel Lezcano
2022-10-03 9:25 ` [PATCH v8 25/29] thermal/drivers/ti: Remove unused macros ti_thermal_get_trip_value() / ti_thermal_trip_is_valid() Daniel Lezcano
2022-10-03 9:25 ` [PATCH v8 26/29] thermal/drivers/acerhdf: Use generic thermal_zone_get_trip() function Daniel Lezcano
2022-10-03 9:26 ` [PATCH v8 27/29] thermal/drivers/cxgb4: " Daniel Lezcano
2022-10-03 9:26 ` [PATCH v8 28/29] thermal/intel/int340x: Replace parameter to simplify Daniel Lezcano
2022-10-03 9:26 ` [PATCH v8 29/29] thermal/drivers/intel: Use generic thermal_zone_get_trip() function Daniel Lezcano
2022-10-03 14:10 ` [PATCH v8 00/29] Rework the trip points creation Marek Szyprowski
2022-10-03 15:36 ` Daniel Lezcano
2022-10-03 21:18 ` Daniel Lezcano
2022-10-05 12:37 ` Daniel Lezcano
2022-10-05 13:05 ` Marek Szyprowski
2022-10-06 6:55 ` Daniel Lezcano
2022-10-06 16:25 ` Marek Szyprowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZA8TPDpEVanOpjEp@shredder \
--to=idosch@idosch$(echo .)org \
--cc=agross@kernel$(echo .)org \
--cc=alim.akhtar@samsung$(echo .)com \
--cc=amitk@kernel$(echo .)org \
--cc=atenart@kernel$(echo .)org \
--cc=bcm-kernel-feedback-list@broadcom$(echo .)com \
--cc=bjorn.andersson@linaro$(echo .)org \
--cc=bzolnier@gmail$(echo .)com \
--cc=daniel.lezcano@linaro$(echo .)org \
--cc=danieller@nvidia$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=digetx@gmail$(echo .)com \
--cc=edubezval@gmail$(echo .)com \
--cc=edumazet@google$(echo .)com \
--cc=f.fainelli@gmail$(echo .)com \
--cc=festevam@gmail$(echo .)com \
--cc=hayashi.kunihiko@socionext$(echo .)com \
--cc=hdegoede@redhat$(echo .)com \
--cc=j-keerthy@ti$(echo .)com \
--cc=jonathanh@nvidia$(echo .)com \
--cc=kernel@pengutronix$(echo .)de \
--cc=krzysztof.kozlowski@linaro$(echo .)org \
--cc=kuba@kernel$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-arm-msm@vger$(echo .)kernel.org \
--cc=linux-imx@nxp$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-omap@vger$(echo .)kernel.org \
--cc=linux-pm@vger$(echo .)kernel.org \
--cc=linux-renesas-soc@vger$(echo .)kernel.org \
--cc=linux-rpi-kernel@lists$(echo .)infradead.org \
--cc=linux-samsung-soc@vger$(echo .)kernel.org \
--cc=linux-tegra@vger$(echo .)kernel.org \
--cc=lukasz.luba@arm$(echo .)com \
--cc=markgross@kernel$(echo .)org \
--cc=mhiramat@kernel$(echo .)org \
--cc=miquel.raynal@bootlin$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=niklas.soderlund@ragnatech$(echo .)se \
--cc=nsaenz@kernel$(echo .)org \
--cc=pabeni@redhat$(echo .)com \
--cc=peter@piie$(echo .)net \
--cc=petrm@nvidia$(echo .)com \
--cc=platform-driver-x86@vger$(echo .)kernel.org \
--cc=rafael.j.wysocki@intel$(echo .)com \
--cc=rafael@kernel$(echo .)org \
--cc=rajur@chelsio$(echo .)com \
--cc=rjui@broadcom$(echo .)com \
--cc=rui.zhang@intel$(echo .)com \
--cc=s.hauer@pengutronix$(echo .)de \
--cc=sbranden@broadcom$(echo .)com \
--cc=shawnguo@kernel$(echo .)org \
--cc=srinivas.pandruvada@linux$(echo .)intel.com \
--cc=support.opensource@diasemi$(echo .)com \
--cc=thara.gopinath@linaro$(echo .)org \
--cc=thierry.reding@gmail$(echo .)com \
--cc=vadimp@nvidia$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox