From: Lorenzo Bianconi <lorenzo@kernel•org>
To: Eric Dumazet <edumazet@google•com>
Cc: Matthieu Baerts <matthieu.baerts@tessares•net>,
netdev@vger•kernel.org, bpf@vger•kernel.org, davem@davemloft•net,
kuba@kernel•org, pabeni@redhat•com, ast@kernel•org,
daniel@iogearbox•net, hawk@kernel•org, john.fastabend@gmail•com,
saeedm@nvidia•com, leon@kernel•org, shayagr@amazon•com,
akiyano@amazon•com, darinzon@amazon•com, sgoutham@marvell•com,
lorenzo.bianconi@redhat•com, toke@redhat•com,
teknoraver@meta•com, ttoukan.linux@gmail•com
Subject: Re: [PATCH net v2 6/8] veth: take into account device reconfiguration for xdp_features flag
Date: Mon, 13 Mar 2023 17:47:49 +0100 [thread overview]
Message-ID: <ZA9TtSkEYavvdd0f@lore-desk> (raw)
In-Reply-To: <CANn89iJEtCp1jUDkW9e4v0tbB0w8TjFczS0YSJcYDOVBeL5zhA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1661 bytes --]
> On Mon, Mar 13, 2023 at 9:36 AM Lorenzo Bianconi <lorenzo@kernel•org> wrote:
> >
> > > On Mon, Mar 13, 2023 at 8:50 AM Eric Dumazet <edumazet@google•com> wrote:
> > > >
> > > > On Mon, Mar 13, 2023 at 7:15 AM Matthieu Baerts
> > > > <matthieu.baerts@tessares•net> wrote:
> > > > >
> > > > > Hi Lorenzo,
> > > > >
> > > > > On 09/03/2023 13:25, Lorenzo Bianconi wrote:
> > > > > > Take into account tx/rx queues reconfiguration setting device
> > > > > > xdp_features flag. Moreover consider NETIF_F_GRO flag in order to enable
> > > > > > ndo_xdp_xmit callback.
> > > > > >
> > > > > > Fixes: 66c0e13ad236 ("drivers: net: turn on XDP features")
> > > > > > Signed-off-by: Lorenzo Bianconi <lorenzo@kernel•org>
> > > > >
> > > > > Thank you for the modification.
> > > > >
> > > > > Unfortunately, 'git bisect' just told me this modification is the origin
> > > > > of a new WARN when using veth in a netns:
> > > > >
> > > > >
> > > > > ###################### 8< ######################
> > > > >
> > > > > =============================
> > > > > WARNING: suspicious RCU usage
> > > > > 6.3.0-rc1-00144-g064d70527aaa #149 Not tainted
> > > > > -----------------------------
> > > > > drivers/net/veth.c:1265 suspicious rcu_dereference_check() usage!
> > > > >
> > > > > other info that might help us debug this:
> > > > >
> > > >
> > > > Same observation here, I am releasing a syzbot report with a repro.
> > > >
> > > >
> > >
> > > I guess a fix would be:
> > >
> >
> > Acked-by: Lorenzo Bianconi <lorenzo@kernel•org>
>
> Can you submit a formal fix ?
ack, will do.
Regards,
Lorenzo
>
> Thanks.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2023-03-13 16:48 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-09 12:25 [PATCH net v2 0/8] update xdp_features flag according to NIC re-configuration Lorenzo Bianconi
2023-03-09 12:25 ` [PATCH net v2 1/8] tools: ynl: fix render-max for flags definition Lorenzo Bianconi
2023-03-09 12:25 ` [PATCH net v2 2/8] tools: ynl: fix get_mask utility routine Lorenzo Bianconi
2023-03-09 12:25 ` [PATCH net v2 3/8] xdp: add xdp_set_features_flag " Lorenzo Bianconi
2023-03-09 12:25 ` [PATCH net v2 4/8] net: thunderx: take into account xdp_features setting tx/rx queues Lorenzo Bianconi
2023-03-09 12:25 ` [PATCH net v2 5/8] net: ena: " Lorenzo Bianconi
2023-03-09 12:25 ` [PATCH net v2 6/8] veth: take into account device reconfiguration for xdp_features flag Lorenzo Bianconi
2023-03-13 14:15 ` Matthieu Baerts
2023-03-13 15:50 ` Eric Dumazet
2023-03-13 15:53 ` Eric Dumazet
2023-03-13 16:31 ` Matthieu Baerts
2023-03-13 16:35 ` Lorenzo Bianconi
2023-03-13 16:37 ` Eric Dumazet
2023-03-13 16:47 ` Lorenzo Bianconi [this message]
2023-04-06 0:56 ` Martin KaFai Lau
2023-03-09 12:25 ` [PATCH net v2 7/8] net/mlx5e: " Lorenzo Bianconi
2023-03-15 23:39 ` Jakub Kicinski
2023-03-16 0:29 ` Jakub Kicinski
2023-03-16 2:46 ` Saeed Mahameed
2023-03-16 2:53 ` Jakub Kicinski
2023-03-16 5:03 ` Saeed Mahameed
2023-03-16 5:37 ` Jakub Kicinski
2023-03-09 12:25 ` [PATCH net v2 8/8] mvpp2: take care of xdp_features when reconfiguring queues Lorenzo Bianconi
2023-03-11 5:50 ` [PATCH net v2 0/8] update xdp_features flag according to NIC re-configuration patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZA9TtSkEYavvdd0f@lore-desk \
--to=lorenzo@kernel$(echo .)org \
--cc=akiyano@amazon$(echo .)com \
--cc=ast@kernel$(echo .)org \
--cc=bpf@vger$(echo .)kernel.org \
--cc=daniel@iogearbox$(echo .)net \
--cc=darinzon@amazon$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=hawk@kernel$(echo .)org \
--cc=john.fastabend@gmail$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=leon@kernel$(echo .)org \
--cc=lorenzo.bianconi@redhat$(echo .)com \
--cc=matthieu.baerts@tessares$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=saeedm@nvidia$(echo .)com \
--cc=sgoutham@marvell$(echo .)com \
--cc=shayagr@amazon$(echo .)com \
--cc=teknoraver@meta$(echo .)com \
--cc=toke@redhat$(echo .)com \
--cc=ttoukan.linux@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox