From: Sam Ravnborg <sam@ravnborg•org>
To: Rob Herring <robh@kernel•org>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro•org>,
devicetree@vger•kernel.org, Miguel Ojeda <ojeda@kernel•org>,
Benson Leung <bleung@chromium•org>,
Guenter Roeck <groeck@chromium•org>,
Stephen Boyd <sboyd@kernel•org>,
Andrzej Hajda <andrzej.hajda@intel•com>,
Neil Armstrong <neil.armstrong@linaro•org>,
Robert Foss <rfoss@kernel•org>,
Thierry Reding <thierry.reding@gmail•com>,
MyungJoo Ham <myungjoo.ham@samsung•com>,
Chanwoo Choi <cw00.choi@samsung•com>,
Linus Walleij <linus.walleij@linaro•org>,
Bartosz Golaszewski <brgl@bgdev•pl>, Pavel Machek <pavel@ucw•cz>,
Lee Jones <lee@kernel•org>,
Mauro Carvalho Chehab <mchehab@kernel•org>,
"David S. Miller" <davem@davemloft•net>,
Eric Dumazet <edumazet@google•com>,
Jakub Kicinski <kuba@kernel•org>, Paolo Abeni <pabeni@redhat•com>,
Wolfgang Grandegger <wg@grandegger•com>,
Kalle Valo <kvalo@kernel•org>, Sebastian Reichel <sre@kernel•org>,
Mark Brown <broonie@kernel•org>,
Greg Kroah-Hartman <gregkh@linuxfoundation•org>,
linux-clk@vger•kernel.org, dri-devel@lists•freedesktop.org,
linux-gpio@vger•kernel.org, linux-i2c@vger•kernel.org,
linux-leds@vger•kernel.org, linux-media@vger•kernel.org,
netdev@vger•kernel.org, linux-can@vger•kernel.org,
linux-wireless@vger•kernel.org, linux-pm@vger•kernel.org,
alsa-devel@alsa-project•org, linux-usb@vger•kernel.org
Subject: Re: [PATCH] dt-bindings: Fix SPI and I2C bus node names in examples
Date: Thu, 2 Mar 2023 17:45:04 +0100 [thread overview]
Message-ID: <ZADSkGa6dK4H9p75@ravnborg.org> (raw)
In-Reply-To: <20230228215433.3944508-1-robh@kernel.org>
Hi Rob.
> .../bindings/display/bridge/analogix,anx7625.yaml | 2 +-
> .../bindings/display/bridge/anx6345.yaml | 2 +-
> .../bindings/display/bridge/lontium,lt8912b.yaml | 2 +-
> .../bindings/display/bridge/nxp,ptn3460.yaml | 2 +-
> .../bindings/display/bridge/ps8640.yaml | 2 +-
> .../bindings/display/bridge/sil,sii9234.yaml | 2 +-
> .../bindings/display/bridge/ti,dlpc3433.yaml | 2 +-
> .../bindings/display/bridge/toshiba,tc358762.yaml | 2 +-
> .../bindings/display/bridge/toshiba,tc358768.yaml | 2 +-
> .../bindings/display/panel/nec,nl8048hl11.yaml | 2 +-
Acked-by: Sam Ravnborg <sam@ravnborg•org>
> index 669f70b1b4c4..8bd58913804a 100644
> --- a/Documentation/devicetree/bindings/display/solomon,ssd1307fb.yaml
> +++ b/Documentation/devicetree/bindings/display/solomon,ssd1307fb.yaml
> @@ -226,7 +226,7 @@ unevaluatedProperties: false
>
> examples:
> - |
> - i2c1 {
> + i2c {
> #address-cells = <1>;
> #size-cells = <0>;
>
> @@ -239,7 +239,7 @@ examples:
>
> ssd1306_i2c: oled@3d {
> compatible = "solomon,ssd1306";
> - reg = <0x3c>;
> + reg = <0x3d>;
> pwms = <&pwm 4 3000>;
> reset-gpios = <&gpio2 7>;
> solomon,com-lrremap;
I can see this align the example with i2c-mux-gpio.yaml so the change
should be fine. I am just positive surprised the tooling caught it.
The change is
Acked-by: Sam Ravnborg <sam@ravnborg•org>
the above was just me thinking loud.
Sam
next prev parent reply other threads:[~2023-03-02 16:45 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-28 21:54 [PATCH] dt-bindings: Fix SPI and I2C bus node names in examples Rob Herring
2023-02-28 21:58 ` Mark Brown
2023-03-01 6:51 ` Wolfram Sang
2023-03-01 7:42 ` Marc Kleine-Budde
2023-03-01 8:52 ` Lee Jones
2023-03-01 14:45 ` Simon Glass
2023-03-01 23:43 ` Sebastian Reichel
2023-03-02 16:45 ` Sam Ravnborg [this message]
[not found] ` <CANiq72mm9qX8uuS2y_vvtcza2hAgG3zFEy24koQTfSEOWkKDYQ@mail.gmail.com>
2023-03-06 8:16 ` Robin van der Gracht
2023-03-06 9:26 ` Bartosz Golaszewski
2023-03-08 14:10 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZADSkGa6dK4H9p75@ravnborg.org \
--to=sam@ravnborg$(echo .)org \
--cc=alsa-devel@alsa-project$(echo .)org \
--cc=andrzej.hajda@intel$(echo .)com \
--cc=bleung@chromium$(echo .)org \
--cc=brgl@bgdev$(echo .)pl \
--cc=broonie@kernel$(echo .)org \
--cc=cw00.choi@samsung$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=dri-devel@lists$(echo .)freedesktop.org \
--cc=edumazet@google$(echo .)com \
--cc=gregkh@linuxfoundation$(echo .)org \
--cc=groeck@chromium$(echo .)org \
--cc=krzysztof.kozlowski+dt@linaro$(echo .)org \
--cc=kuba@kernel$(echo .)org \
--cc=kvalo@kernel$(echo .)org \
--cc=lee@kernel$(echo .)org \
--cc=linus.walleij@linaro$(echo .)org \
--cc=linux-can@vger$(echo .)kernel.org \
--cc=linux-clk@vger$(echo .)kernel.org \
--cc=linux-gpio@vger$(echo .)kernel.org \
--cc=linux-i2c@vger$(echo .)kernel.org \
--cc=linux-leds@vger$(echo .)kernel.org \
--cc=linux-media@vger$(echo .)kernel.org \
--cc=linux-pm@vger$(echo .)kernel.org \
--cc=linux-usb@vger$(echo .)kernel.org \
--cc=linux-wireless@vger$(echo .)kernel.org \
--cc=mchehab@kernel$(echo .)org \
--cc=myungjoo.ham@samsung$(echo .)com \
--cc=neil.armstrong@linaro$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=ojeda@kernel$(echo .)org \
--cc=pabeni@redhat$(echo .)com \
--cc=pavel@ucw$(echo .)cz \
--cc=rfoss@kernel$(echo .)org \
--cc=robh@kernel$(echo .)org \
--cc=sboyd@kernel$(echo .)org \
--cc=sre@kernel$(echo .)org \
--cc=thierry.reding@gmail$(echo .)com \
--cc=wg@grandegger$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox