From: Simon Horman <simon.horman@corigine•com>
To: Heiner Kallweit <hkallweit1@gmail•com>
Cc: Andrew Lunn <andrew@lunn•ch>,
Russell King - ARM Linux <linux@armlinux•org.uk>,
Paolo Abeni <pabeni@redhat•com>, Jakub Kicinski <kuba@kernel•org>,
Eric Dumazet <edumazet@google•com>,
David Miller <davem@davemloft•net>,
"netdev@vger•kernel.org" <netdev@vger•kernel.org>
Subject: Re: [PATCH net-next] net: phy: improve phy_read_poll_timeout
Date: Tue, 7 Mar 2023 16:42:47 +0100 [thread overview]
Message-ID: <ZAdbd5NLQMkCZrk1@corigine.com> (raw)
In-Reply-To: <6d8274ac-4344-23b4-d9a3-cad4c39517d4@gmail.com>
On Mon, Mar 06, 2023 at 10:51:35PM +0100, Heiner Kallweit wrote:
> cond sometimes is (val & MASK) what may result in a false positive
> if val is a negative errno. We shouldn't evaluate cond if val < 0.
> This has no functional impact here, but it's not nice.
> Therefore switch order of the checks.
>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail•com>
Reviewed-by: Simon Horman <simon.horman@corigine•com>
next prev parent reply other threads:[~2023-03-07 15:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-06 21:51 [PATCH net-next] net: phy: improve phy_read_poll_timeout Heiner Kallweit
2023-03-07 15:42 ` Simon Horman [this message]
2023-03-08 1:56 ` Andrew Lunn
2023-03-08 2:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZAdbd5NLQMkCZrk1@corigine.com \
--to=simon.horman@corigine$(echo .)com \
--cc=andrew@lunn$(echo .)ch \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=hkallweit1@gmail$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=linux@armlinux$(echo .)org.uk \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox