From: Simon Horman <simon.horman@corigine•com>
To: Harshit Mogalapalli <harshit.m.mogalapalli@oracle•com>
Cc: error27@gmail•com, Kalle Valo <kvalo@kernel•org>,
"David S. Miller" <davem@davemloft•net>,
Eric Dumazet <edumazet@google•com>,
Jakub Kicinski <kuba@kernel•org>, Paolo Abeni <pabeni@redhat•com>,
P Praneesh <quic_ppranees@quicinc•com>,
Karthikeyan Periyasamy <quic_periyasa@quicinc•com>,
Jeff Johnson <quic_jjohnson@quicinc•com>,
Bhagavathi Perumal S <quic_bperumal@quicinc•com>,
Wen Gong <quic_wgong@quicinc•com>,
ath12k@lists•infradead.org, linux-wireless@vger•kernel.org,
netdev@vger•kernel.org, linux-kernel@vger•kernel.org
Subject: Re: [PATCH] wifi: ath12k: Add missing unwind goto in ath12k_pci_probe()
Date: Wed, 8 Mar 2023 12:48:49 +0100 [thread overview]
Message-ID: <ZAh2IeS3TnyllK33@corigine.com> (raw)
In-Reply-To: <20230307104706.240119-1-harshit.m.mogalapalli@oracle.com>
On Tue, Mar 07, 2023 at 02:47:06AM -0800, Harshit Mogalapalli wrote:
> Smatch Warns:
> drivers/net/wireless/ath/ath12k/pci.c:1198 ath12k_pci_probe()
> warn: missing unwind goto?
>
> Store the error value in ret and use correct label with a goto.
>
> Fixes: d889913205cf ("wifi: ath12k: driver for Qualcomm Wi-Fi 7 devices")
> Reported-by: Dan Carpenter <error27@gmail•com>
> Link: https://lore.kernel.org/all/Y+426q6cfkEdb5Bv@kili/
> Suggested-by: Dan Carpenter <error27@gmail•com>
> Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@oracle•com>
> ---
> Only Compile tested, found with Smatch.
Reviewed-by: Simon Horman <simon.horman@corigine•com>
next prev parent reply other threads:[~2023-03-08 11:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-07 10:47 [PATCH] wifi: ath12k: Add missing unwind goto in ath12k_pci_probe() Harshit Mogalapalli
2023-03-08 11:48 ` Simon Horman [this message]
2023-03-15 10:18 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZAh2IeS3TnyllK33@corigine.com \
--to=simon.horman@corigine$(echo .)com \
--cc=ath12k@lists$(echo .)infradead.org \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=error27@gmail$(echo .)com \
--cc=harshit.m.mogalapalli@oracle$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=kvalo@kernel$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-wireless@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=quic_bperumal@quicinc$(echo .)com \
--cc=quic_jjohnson@quicinc$(echo .)com \
--cc=quic_periyasa@quicinc$(echo .)com \
--cc=quic_ppranees@quicinc$(echo .)com \
--cc=quic_wgong@quicinc$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox