From: Simon Horman <simon.horman@corigine•com>
To: Neeraj Sanjay Kale <neeraj.sanjaykale@nxp•com>
Cc: davem@davemloft•net, edumazet@google•com, kuba@kernel•org,
pabeni@redhat•com, robh+dt@kernel•org,
krzysztof.kozlowski+dt@linaro•org, marcel@holtmann•org,
johan.hedberg@gmail•com, luiz.dentz@gmail•com,
gregkh@linuxfoundation•org, jirislaby@kernel•org,
alok.a.tiwari@oracle•com, hdanton@sina•com,
ilpo.jarvinen@linux•intel.com, leon@kernel•org,
netdev@vger•kernel.org, devicetree@vger•kernel.org,
linux-kernel@vger•kernel.org, linux-bluetooth@vger•kernel.org,
linux-serial@vger•kernel.org, amitkumar.karwar@nxp•com,
rohit.fule@nxp•com, sherry.sun@nxp•com
Subject: Re: [PATCH v8 1/3] serdev: Add method to assert break signal over tty UART port
Date: Sat, 11 Mar 2023 13:33:40 +0100 [thread overview]
Message-ID: <ZAx1JOvjgOOYCNY9@corigine.com> (raw)
In-Reply-To: <20230310181921.1437890-2-neeraj.sanjaykale@nxp.com>
On Fri, Mar 10, 2023 at 11:49:19PM +0530, Neeraj Sanjay Kale wrote:
> Adds serdev_device_break_ctl() and an implementation for ttyport.
> This function simply calls the break_ctl in tty layer, which can
> assert a break signal over UART-TX line, if the tty and the
> underlying platform and UART peripheral supports this operation.
>
> Signed-off-by: Neeraj Sanjay Kale <neeraj.sanjaykale@nxp•com>
> ---
> v3: Add details to the commit message. (Greg KH)
...
> diff --git a/include/linux/serdev.h b/include/linux/serdev.h
> index 66f624fc618c..c065ef1c82f1 100644
> --- a/include/linux/serdev.h
> +++ b/include/linux/serdev.h
...
> @@ -255,6 +257,10 @@ static inline int serdev_device_set_tiocm(struct serdev_device *serdev, int set,
> {
> return -ENOTSUPP;
> }
> +static inline int serdev_device_break_ctl(struct serdev_device *serdev, int break_state)
> +{
> + return -EOPNOTSUPP;
Is the use of -EOPNOTSUPP intentional here?
I see -ENOTSUPP is used elsewhere in this file.
> +}
> static inline int serdev_device_write(struct serdev_device *sdev, const unsigned char *buf,
> size_t count, unsigned long timeout)
> {
> --
> 2.34.1
>
next prev parent reply other threads:[~2023-03-11 12:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-10 18:19 [PATCH v8 0/3] Add support for NXP bluetooth chipsets Neeraj Sanjay Kale
2023-03-10 18:19 ` [PATCH v8 1/3] serdev: Add method to assert break signal over tty UART port Neeraj Sanjay Kale
2023-03-11 12:33 ` Simon Horman [this message]
2023-03-12 7:01 ` Neeraj sanjay kale
2023-03-12 19:12 ` Simon Horman
2023-03-13 4:19 ` Neeraj sanjay kale
2023-03-13 12:06 ` Simon Horman
2023-03-13 14:14 ` Neeraj sanjay kale
2023-03-10 18:19 ` [PATCH v8 2/3] dt-bindings: net: bluetooth: Add NXP bluetooth support Neeraj Sanjay Kale
2023-03-10 18:19 ` [PATCH v8 3/3] Bluetooth: NXP: Add protocol support for NXP Bluetooth chipsets Neeraj Sanjay Kale
2023-03-13 9:01 ` Ilpo Järvinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZAx1JOvjgOOYCNY9@corigine.com \
--to=simon.horman@corigine$(echo .)com \
--cc=alok.a.tiwari@oracle$(echo .)com \
--cc=amitkumar.karwar@nxp$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=edumazet@google$(echo .)com \
--cc=gregkh@linuxfoundation$(echo .)org \
--cc=hdanton@sina$(echo .)com \
--cc=ilpo.jarvinen@linux$(echo .)intel.com \
--cc=jirislaby@kernel$(echo .)org \
--cc=johan.hedberg@gmail$(echo .)com \
--cc=krzysztof.kozlowski+dt@linaro$(echo .)org \
--cc=kuba@kernel$(echo .)org \
--cc=leon@kernel$(echo .)org \
--cc=linux-bluetooth@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-serial@vger$(echo .)kernel.org \
--cc=luiz.dentz@gmail$(echo .)com \
--cc=marcel@holtmann$(echo .)org \
--cc=neeraj.sanjaykale@nxp$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=robh+dt@kernel$(echo .)org \
--cc=rohit.fule@nxp$(echo .)com \
--cc=sherry.sun@nxp$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox