Subject: Re: [PATCH net 2/2] net/sched: act_api: add specific EXT_WARN_MSG for tc action

From: Hangbin Liu <[email-masked]>
Date: Wed, 15 Mar 2023 17:39:59 +0800

On Wed, Mar 15, 2023 at 12:45:32AM -0700, Jakub Kicinski wrote:
> On Tue, 14 Mar 2023 14:58:02 +0800 Hangbin Liu wrote:
> > --- a/include/uapi/linux/rtnetlink.h
> > +++ b/include/uapi/linux/rtnetlink.h
> > @@ -789,6 +789,7 @@ enum {
> >  	TCA_ROOT_FLAGS,
> >  	TCA_ROOT_COUNT,
> >  	TCA_ROOT_TIME_DELTA, /* in msecs */
> > +	TCA_ACT_EXT_WARN_MSG,
> 
> Not TCA_ROOT_EXT_... ?
> All other attrs in this set are called TCA_ROOT_x

Hmm, when we discussed this issue, Jamal suggested to use TCAA_EXT_WARN_MSG.
I expand it to TCA_ACT_EXT_WARN_MSG to correspond with the format of TCA_*.
But your suggest TCA_ROOT_EXT_ also makes sense. I'm OK to change it.

Jamal, what do you think?

Thanks
Hangbin