Subject: Re: [PATCH RFC v6 6/6] ptp_ocp: implement DPLL ops

From: Jiri Pirko <[email-masked]>
Date: Thu, 16 Mar 2023 13:12:57 +0100

Sun, Mar 12, 2023 at 03:28:07AM CET, [email-masked] wrote:

[...]

>@@ -4243,6 +4430,8 @@ ptp_ocp_remove(struct pci_dev *pdev)
> 	struct ptp_ocp *bp = pci_get_drvdata(pdev);
> 	struct devlink *devlink = priv_to_devlink(bp);
> 

You are missing pins unregister and put here.

Btw, It would be probably good to add a WARN_ON into
dpll_device_unregister() to catch bugs like this one.

>+	dpll_device_unregister(bp->dpll);
>+	dpll_device_put(bp->dpll);
> 	devlink_unregister(devlink);
> 	ptp_ocp_detach(bp);
> 	pci_disable_device(pdev);
>-- 
>2.34.1
>