Subject: Re: [PATCH net v2 0/2] Fix PHY handle no longer parsing

From: "Russell King (Oracle)" <[email-masked]>
Date: Tue, 21 Mar 2023 10:22:13 +0000

On Tue, Mar 21, 2023 at 08:37:48AM +0000, Sit, Michael Wei Hong wrote:
> 
> 
> > -----Original Message-----
> > From: Russell King <[email-masked]>
> > Sent: Saturday, March 18, 2023 4:54 AM
> > To: Sit, Michael Wei Hong <[email-masked]>
> > Cc: Giuseppe Cavallaro <[email-masked]>; Alexandre
> > Torgue <[email-masked]>; Jose Abreu
> > <[email-masked]>; David S . Miller
> > <[email-masked]>; Eric Dumazet
> > <[email-masked]>; Jakub Kicinski <[email-masked]>;
> > Paolo Abeni <[email-masked]>; Maxime Coquelin
> > <[email-masked]>; Ong, Boon Leong
> > <[email-masked]>; [email-masked]; linux-
> > [email-masked]; linux-arm-
> > [email-masked]; [email-masked]; Looi,
> > Hong Aun <[email-masked]>; Voon, Weifeng
> > <[email-masked]>; Lai, Peter Jun Ann
> > <[email-masked]>
> > Subject: Re: [PATCH net v2 0/2] Fix PHY handle no longer parsing
> > 
> > On Tue, Mar 14, 2023 at 03:02:06PM +0800, Michael Sit Wei Hong
> > wrote:
> > > After the fixed link support was introduced, it is observed that
> > PHY
> > > no longer attach to the MAC properly.
> > 
> > You are aware, I hope, that fixed-link and having a PHY are
> > mutually exclusive?
> > 
> > In other words, you can't use fixed-link to specify parameters for
> > a PHY.
> > 
> Yes but when the fixed-link support code was added, all our non
> fixed-link devices are not attaching the PHYs to the MACs, hence
> the reason for this patch series, to ensure both fixed-link and
> non fixed-link scenarios work properly.

Ah, it's the "there should be a PHY here" case you're trying to cater
for, rather than actually a fixed-link.

So, how about adding a helper that is basically:

bool phylink_expects_phy(struct phylink *phylink)
{
	return pl->cfg_link_an_mode == MLO_AN_PHY;
}
EXPORT_SYMBOL_GPL(phylink_expects_phy);

and use that to test whether you need to manually find a PHY to attach,
rather than trying to detect whether a fixed-link stanza appears in
firmware?

Thanks.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!