From: Simon Horman <simon.horman@corigine•com>
To: joshwash@google•com
Cc: netdev@vger•kernel.org, davem@davemloft•net, kuba@kernel•org
Subject: Re: [PATCH net v2] gve: Cache link_speed value from device
Date: Wed, 22 Mar 2023 17:03:56 +0100 [thread overview]
Message-ID: <ZBsm7MkHeuZahQJK@corigine.com> (raw)
In-Reply-To: <20230321172332.91678-1-joshwash@google.com>
On Tue, Mar 21, 2023 at 10:23:32AM -0700, joshwash@google•com wrote:
> From: Joshua Washington <joshwash@google•com>
>
> The link speed is never changed for the uptime of a VM, and the current
> implementation sends an admin queue command for each call. Admin queue
> command invocations have nontrivial overhead (e.g., VM exits), which can
> be disruptive to users if triggered frequently. Our telemetry data shows
> that there are VMs that make frequent calls to this admin queue command.
> Caching the result of the original admin queue command would eliminate
> the need to send multiple admin queue commands on subsequent calls to
> retrieve link speed.
>
> Fixes: 7e074d5a76ca ("gve: Enable Link Speed Reporting in the driver.")
> Signed-off-by: Joshua Washington <joshwash@google•com>
Reviewed-by: Simon Horman <simon.horman@corigine•com>
next prev parent reply other threads:[~2023-03-22 16:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-21 17:23 [PATCH net v2] gve: Cache link_speed value from device joshwash
2023-03-22 16:03 ` Simon Horman [this message]
2023-03-23 5:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZBsm7MkHeuZahQJK@corigine.com \
--to=simon.horman@corigine$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=joshwash@google$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox