Subject: Re: [PATCH net] net: enetc: fix aggregate RMON counters not showing the ranges

From: Simon Horman <[email-masked]>
Date: Wed, 22 Mar 2023 17:46:53 +0100

On Wed, Mar 22, 2023 at 01:28:31AM +0200, Vladimir Oltean wrote:
> When running "ethtool -S eno0 --groups rmon" without an explicit "--src
> emac|pmac" argument, the kernel will not report
> rx-rmon-etherStatsPkts64to64Octets, rx-rmon-etherStatsPkts65to127Octets,
> etc. This is because on ETHTOOL_MAC_STATS_SRC_AGGREGATE, we do not
> populate the "ranges" argument.
> 
> ocelot_port_get_rmon_stats() does things differently and things work
> there. I had forgotten to make sure that the code is structured the same
> way in both drivers, so do that now.
> 
> Fixes: cf52bd238b75 ("net: enetc: add support for MAC Merge statistics counters")
> Signed-off-by: Vladimir Oltean <[email-masked]>

This feels a bit more like an enhancement than a fix to me,
but I don't feel strongly about it.

Reviewed-by: Simon Horman <[email-masked]>