From: Simon Horman <simon.horman@corigine•com>
To: Alex Elder <elder@linaro•org>
Cc: davem@davemloft•net, edumazet@google•com, kuba@kernel•org,
pabeni@redhat•com, caleb.connolly@linaro•org, mka@chromium•org,
evgreen@chromium•org, andersson@kernel•org,
quic_cpratapa@quicinc•com, quic_avuyyuru@quicinc•com,
quic_jponduru@quicinc•com, quic_subashab@quicinc•com,
elder@kernel•org, netdev@vger•kernel.org,
linux-arm-msm@vger•kernel.org, linux-kernel@vger•kernel.org
Subject: Re: [PATCH net-next] net: ipa: add IPA v5.0 to ipa_version_string()
Date: Wed, 22 Mar 2023 21:56:28 +0100 [thread overview]
Message-ID: <ZBtrfLOh3EKBKW+F@corigine.com> (raw)
In-Reply-To: <20230322144742.2203947-1-elder@linaro.org>
On Wed, Mar 22, 2023 at 09:47:42AM -0500, Alex Elder wrote:
> In the IPA device sysfs directory, the "version" file can be read to
> find out what IPA version is implemented. The content of this file
> is supplied by ipa_version_string(), which needs to be updated to
> properly handle IPA v5.0.
>
> Signed-off-by: Alex Elder <elder@linaro•org>
Hi Alex,
this patch looks fine. But I am curious.
Should IPA_VERSION_5_1 and IPA_VERSION_5_5 also be added?
> ---
> This should have been included in the previous series...
>
> drivers/net/ipa/ipa_sysfs.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/net/ipa/ipa_sysfs.c b/drivers/net/ipa/ipa_sysfs.c
> index 14bd2f9030453..2ff09ce343b73 100644
> --- a/drivers/net/ipa/ipa_sysfs.c
> +++ b/drivers/net/ipa/ipa_sysfs.c
> @@ -36,6 +36,8 @@ static const char *ipa_version_string(struct ipa *ipa)
> return "4.9";
> case IPA_VERSION_4_11:
> return "4.11";
> + case IPA_VERSION_5_0:
> + return "5.0";
> default:
> return "0.0"; /* Won't happen (checked at probe time) */
> }
> --
> 2.34.1
>
next prev parent reply other threads:[~2023-03-22 20:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-22 14:47 [PATCH net-next] net: ipa: add IPA v5.0 to ipa_version_string() Alex Elder
2023-03-22 20:56 ` Simon Horman [this message]
2023-03-22 21:08 ` Alex Elder
2023-03-22 21:18 ` Simon Horman
2023-03-24 4:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZBtrfLOh3EKBKW+F@corigine.com \
--to=simon.horman@corigine$(echo .)com \
--cc=andersson@kernel$(echo .)org \
--cc=caleb.connolly@linaro$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=elder@kernel$(echo .)org \
--cc=elder@linaro$(echo .)org \
--cc=evgreen@chromium$(echo .)org \
--cc=kuba@kernel$(echo .)org \
--cc=linux-arm-msm@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=mka@chromium$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=quic_avuyyuru@quicinc$(echo .)com \
--cc=quic_cpratapa@quicinc$(echo .)com \
--cc=quic_jponduru@quicinc$(echo .)com \
--cc=quic_subashab@quicinc$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox