Subject: Re: [PATCH RFC net-next 1/7] software node: allow named software node to be created

From: Andy Shevchenko <[email-masked]>
Date: Thu, 23 Mar 2023 15:59:07 +0200

On Wed, Mar 22, 2023 at 11:59:55AM +0000, Russell King wrote:
> From: Vladimir Oltean <[email-masked]>
> 
> Allow a named software node to be created, which is needed for software
> nodes for a fixed-link specification for DSA.

...

> +fwnode_create_named_software_node(const struct property_entry *properties,
> +				  const struct fwnode_handle *parent,
> +				  const char *name)
>  {
>  	struct fwnode_handle *fwnode;
>  	struct software_node *node;
> @@ -930,6 +931,7 @@ fwnode_create_software_node(const struct property_entry *properties,
>  		return ERR_CAST(node);
>  
>  	node->parent = p ? p->node : NULL;
> +	node->name = name;

The same question stays as before: how can we be sure that the name is unique
and we won't have a collision?

>  	fwnode = swnode_register(node, p, 1);
>  	if (IS_ERR(fwnode))
> @@ -937,6 +939,14 @@ fwnode_create_software_node(const struct property_entry *properties,
>  
>  	return fwnode;
>  }
> +EXPORT_SYMBOL_GPL(fwnode_create_named_software_node);

-- 
With Best Regards,
Andy Shevchenko