Subject: Re: [PATCH] mISDN: remove unused vpm_read_address and cpld_read_reg functions

From: Simon Horman <[email-masked]>
Date: Thu, 23 Mar 2023 19:37:50 +0100

On Thu, Mar 23, 2023 at 12:13:43PM -0400, Tom Rix wrote:
> clang with W=1 reports
> drivers/isdn/hardware/mISDN/hfcmulti.c:667:1: error: unused function
>   'vpm_read_address' [-Werror,-Wunused-function]
> vpm_read_address(struct hfc_multi *c)
> ^
> 
> drivers/isdn/hardware/mISDN/hfcmulti.c:643:1: error: unused function
>   'cpld_read_reg' [-Werror,-Wunused-function]
> cpld_read_reg(struct hfc_multi *hc, unsigned char reg)
> ^
> 
> These functions are not used, so remove them.
> 
> Reported-by: Simon Horman <[email-masked]>

FWIIW, says this should go here.

Link: https://lore.kernel.org/netdev/[email-masked]/

> Signed-off-by: Tom Rix <[email-masked]>

Patch looks good, thanks.

Reviewed-by: Simon Horman <[email-masked]>