public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed

From: Hangbin Liu <liuhangbin@gmail•com>
To: Jonathan Toppins <jtoppins@redhat•com>
Cc: netdev@vger•kernel.org, Jay Vosburgh <j.vosburgh@gmail•com>,
	"David S . Miller" <davem@davemloft•net>,
	Jakub Kicinski <kuba@kernel•org>, Paolo Abeni <pabeni@redhat•com>,
	Eric Dumazet <edumazet@google•com>, Liang Li <liali@redhat•com>
Subject: Re: [PATCH net 2/3] selftests: bonding: re-format bond option tests
Date: Wed, 5 Apr 2023 17:57:54 +0800	[thread overview]
Message-ID: <ZC1GInfrzuZ8Rj8p@Laptop-X1> (raw)
In-Reply-To: <ec1b7951-2890-9603-dce3-5623de4b814d@redhat.com>

On Tue, Apr 04, 2023 at 12:34:03PM -0400, Jonathan Toppins wrote:
> > > > I like this idea, we might want to separate network topology from library
> > > > code however. That way a given test case can just include a predefined
> > > 
> > > Would you like to help explain more clear? Separate network topology to where?
> > 
> > 
> > Hi Jon, would you please help explain this part?
> 
> Thanks for the ping. It looks like several test cases build largely the same
> virtual network topology and then execute the test case. I was attempting to
> point out that it might be better to provide a standard network topology and
> then each test case utilizes this standard topology instead of each test
> case rolling its own. Also, with my comment about separating out the
> topology from library code I was accounting for the ability to support
> multiple topologies, fe:
> 
>  bond_lib.sh
>  bond_topo_gateway.sh
>  bond_topo_2.sh
> 
> Then a given test case only includes/sources `bond_topo_gateway.sh` which
> creates the virtual network.

Thank Jon, this is much clear to me now. I'm not good at naming.
For topology with 2 down link devices, 1 client, I plan to name it
bond_topo_2d1c.sh. So 3 down links devices, 2 clients will be
bond_topo_3d2c.sh. If there is no switch between server and client, it could
be bond_topo_2d1c_ns.sh.

I'm not sure if the name is weird to you. Any comments?

Thanks
Hangbin

next prev parent reply	other threads:[~2023-04-05  9:58 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-29 10:18 [PATCH net 0/3] bonding: fix ns validation on backup slaves Hangbin Liu
2023-03-29 10:18 ` [PATCH net 1/3] " Hangbin Liu
2023-03-30 16:46   ` Jonathan Toppins
2023-03-31  4:02   ` Jay Vosburgh
2023-03-29 10:18 ` [PATCH net 2/3] selftests: bonding: re-format bond option tests Hangbin Liu
2023-03-30 16:45   ` Jonathan Toppins
2023-03-31  2:31     ` Hangbin Liu
2023-04-04  2:28       ` Hangbin Liu
2023-04-04 16:34         ` Jonathan Toppins
2023-04-05  9:57           ` Hangbin Liu [this message]
2023-04-06  0:23             ` Jonathan Toppins
2023-03-31  3:55   ` Jay Vosburgh
2023-03-29 10:18 ` [PATCH net 3/3] selftests: bonding: add arp validate test Hangbin Liu
2023-03-30 16:48   ` Jonathan Toppins
2023-03-31  4:00   ` Jay Vosburgh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZC1GInfrzuZ8Rj8p@Laptop-X1 \
    --to=liuhangbin@gmail$(echo .)com \
    --cc=davem@davemloft$(echo .)net \
    --cc=edumazet@google$(echo .)com \
    --cc=j.vosburgh@gmail$(echo .)com \
    --cc=jtoppins@redhat$(echo .)com \
    --cc=kuba@kernel$(echo .)org \
    --cc=liali@redhat$(echo .)com \
    --cc=netdev@vger$(echo .)kernel.org \
    --cc=pabeni@redhat$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox