Subject: Re: [PATCH net-next v2 5/6] sfc: add code to register and unregister encap matches

From: Simon Horman <[email-masked]>
Date: Sun, 26 Mar 2023 11:18:08 +0200

On Thu, Mar 23, 2023 at 08:45:13PM +0000, [email-masked] wrote:
> From: Edward Cree <[email-masked]>
> 
> Add a hashtable to detect duplicate and conflicting matches.  If match
>  is not a duplicate, call MAE functions to add/remove it from OR table.
> Calling code not added yet, so mark the new functions as unused.
> 
> Signed-off-by: Edward Cree <[email-masked]>
> ---
> Changed in v2: replace `unsigned char ipv` with `bool ipv6`, simplifying
>  code (suggested by Michal)

Many bits have been spilt on a minor problem around initialising 'ipv6 [1][2].
But that aside, this looks good to me.

Reviewed-by: Simon Horman <[email-masked]>

[1] https://lore.kernel.org/all/[email-masked]/
[2] https://lore.kernel.org/all/[email-masked]/