Subject: Re: [net-next Patch v5 3/6] octeontx2-pf: qos send queues management

From: Simon Horman <[email-masked]>
Date: Tue, 28 Mar 2023 16:43:21 +0200

On Sun, Mar 26, 2023 at 11:42:42PM +0530, Hariprasad Kelam wrote:
> From: Subbaraya Sundeep <[email-masked]>
> 
> Current implementation is such that the number of Send queues (SQs)
> are decided on the device probe which is equal to the number of online
> cpus. These SQs are allocated and deallocated in interface open and c
> lose calls respectively.
> 
> This patch defines new APIs for initializing and deinitializing Send
> queues dynamically and allocates more number of transmit queues for
> QOS feature.
> 
> Signed-off-by: Subbaraya Sundeep <[email-masked]>
> Signed-off-by: Hariprasad Kelam <[email-masked]>
> Signed-off-by: Sunil Kovvuri Goutham <[email-masked]>

Reviewed-by: Simon Horman <[email-masked]>

> diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c

...

> @@ -1938,6 +1952,12 @@ static netdev_tx_t otx2_xmit(struct sk_buff *skb, struct net_device *netdev)
>  	int qidx = skb_get_queue_mapping(skb);
>  	struct otx2_snd_queue *sq;
>  	struct netdev_queue *txq;
> +	int sq_idx;
> +
> +	/* XDP SQs are not mapped with TXQs
> +	 * advance qid to derive correct sq maped with QOS

nit: s/maped/mapped/

...