From: Simon Horman <simon.horman@corigine•com>
To: Wolfram Sang <wsa+renesas@sang-engineering•com>
Cc: netdev@vger•kernel.org, linux-renesas-soc@vger•kernel.org,
Sergey Shtylyov <s.shtylyov@omp•ru>,
"David S. Miller" <davem@davemloft•net>,
Eric Dumazet <edumazet@google•com>,
Jakub Kicinski <kuba@kernel•org>, Paolo Abeni <pabeni@redhat•com>,
linux-kernel@vger•kernel.org
Subject: Re: [PATCH net-next v2] Revert "sh_eth: remove open coded netif_running()"
Date: Tue, 28 Mar 2023 17:03:26 +0200 [thread overview]
Message-ID: <ZCMBvv7Qm3ApnD/i@corigine.com> (raw)
In-Reply-To: <20230327152112.15635-1-wsa+renesas@sang-engineering.com>
On Mon, Mar 27, 2023 at 05:21:12PM +0200, Wolfram Sang wrote:
> This reverts commit ce1fdb065695f49ef6f126d35c1abbfe645d62d5. It turned
> out this actually introduces a race condition. netif_running() is not a
> suitable check for get_stats.
>
> Reported-by: Sergey Shtylyov <s.shtylyov@omp•ru>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering•com>
Reviewed-by: Simon Horman <simon.horman@corigine•com>
next prev parent reply other threads:[~2023-03-28 15:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-27 15:21 [PATCH net-next v2] Revert "sh_eth: remove open coded netif_running()" Wolfram Sang
2023-03-27 18:06 ` Sergey Shtylyov
2023-03-28 15:03 ` Simon Horman [this message]
2023-03-29 2:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZCMBvv7Qm3ApnD/i@corigine.com \
--to=simon.horman@corigine$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-renesas-soc@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=s.shtylyov@omp$(echo .)ru \
--cc=wsa+renesas@sang-engineering$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox