From: Simon Horman <simon.horman@corigine•com>
To: Michael Chan <michael.chan@broadcom•com>
Cc: davem@davemloft•net, netdev@vger•kernel.org, edumazet@google•com,
kuba@kernel•org, pabeni@redhat•com, gospo@broadcom•com,
Kalesh AP <kalesh-anakkur.purayil@broadcom•com>,
Pavan Chebbi <pavan.chebbi@broadcom•com>,
Somnath Kotur <somnath.kotur@broadcom•com>
Subject: Re: [PATCH net 1/3] bnxt_en: Fix reporting of test result in ethtool selftest
Date: Wed, 29 Mar 2023 15:08:01 +0200 [thread overview]
Message-ID: <ZCQ4MYXuAKiqDuae@corigine.com> (raw)
In-Reply-To: <20230329013021.5205-2-michael.chan@broadcom.com>
On Tue, Mar 28, 2023 at 06:30:19PM -0700, Michael Chan wrote:
> From: Kalesh AP <kalesh-anakkur.purayil@broadcom•com>
>
> When the selftest command fails, driver is not reporting the failure
> by updating the "test->flags" when bnxt_close_nic() fails.
>
> Fixes: eb51365846bc ("bnxt_en: Add basic ethtool -t selftest support.")
> Reviewed-by: Pavan Chebbi <pavan.chebbi@broadcom•com>
> Reviewed-by: Somnath Kotur <somnath.kotur@broadcom•com>
> Signed-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom•com>
> Signed-off-by: Michael Chan <michael.chan@broadcom•com>
Reviewed-by: Simon Horman <simon.horman@corigine•com>
Note: I think this will require a manual backport to get
all the way back to the above referenced commit (v4.12).
I'm unsure if that will need to be addressed in practice.
> ---
> drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c b/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c
> index ec573127b707..7658a06b8d05 100644
> --- a/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c
> +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c
> @@ -3738,6 +3738,7 @@ static void bnxt_self_test(struct net_device *dev, struct ethtool_test *etest,
> bnxt_ulp_stop(bp);
> rc = bnxt_close_nic(bp, true, false);
> if (rc) {
> + etest->flags |= ETH_TEST_FL_FAILED;
> bnxt_ulp_start(bp, rc);
> return;
> }
> --
> 2.18.1
>
next prev parent reply other threads:[~2023-03-29 13:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-29 1:30 [PATCH net 0/3] bnxt_en: 3 Bug fixes Michael Chan
2023-03-29 1:30 ` [PATCH net 1/3] bnxt_en: Fix reporting of test result in ethtool selftest Michael Chan
2023-03-29 13:08 ` Simon Horman [this message]
2023-03-29 17:34 ` Michael Chan
2023-03-29 1:30 ` [PATCH net 2/3] bnxt_en: Fix typo in PCI id to device description string mapping Michael Chan
2023-03-29 13:08 ` Simon Horman
2023-03-29 1:30 ` [PATCH net 3/3] bnxt_en: Add missing 200G link speed reporting Michael Chan
2023-03-29 13:19 ` Simon Horman
2023-03-30 4:50 ` [PATCH net 0/3] bnxt_en: 3 Bug fixes patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZCQ4MYXuAKiqDuae@corigine.com \
--to=simon.horman@corigine$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=gospo@broadcom$(echo .)com \
--cc=kalesh-anakkur.purayil@broadcom$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=michael.chan@broadcom$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=pavan.chebbi@broadcom$(echo .)com \
--cc=somnath.kotur@broadcom$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox