Subject: Re: [Intel-wired-lan] [PATCH net-next 05/15] idpf: add create vport and netdev configuration

From: Simon Horman <[email-masked]>
Date: Fri, 31 Mar 2023 17:46:07 +0200

On Wed, Mar 29, 2023 at 07:03:54AM -0700, Pavan Kumar Linga wrote:
> Add the required support to create a vport by spawning
> the init task. Once the vport is created, initialize and
> allocate the resources needed for it. Configure and register
> a netdev for each vport with all the features supported
> by the device based on the capabilities received from the
> device Control Plane. Spawn the init task till all the default
> vports are created.
> 
> Co-developed-by: Alan Brady <[email-masked]>
> Signed-off-by: Alan Brady <[email-masked]>
> Co-developed-by: Joshua Hay <[email-masked]>
> Signed-off-by: Joshua Hay <[email-masked]>
> Co-developed-by: Madhu Chittim <[email-masked]>
> Signed-off-by: Madhu Chittim <[email-masked]>
> Co-developed-by: Phani Burra <[email-masked]>
> Signed-off-by: Phani Burra <[email-masked]>
> Co-developed-by: Shailendra Bhatnagar <[email-masked]>
> Signed-off-by: Shailendra Bhatnagar <[email-masked]>
> Signed-off-by: Pavan Kumar Linga <[email-masked]>
> Reviewed-by: Sridhar Samudrala <[email-masked]>

Some spelling nits from my side.

> diff --git a/drivers/net/ethernet/intel/idpf/idpf_lib.c b/drivers/net/ethernet/intel/idpf/idpf_lib.c

...

> +/**
> + * idpf_decfg_netdev - Unregister the netdev
> + * @vport: vport for which netdev to be unregistred
> + */

s/unregistred/unregistered/

> +/**
> + * idpf_deinit_task - Device deinit routine
> + * @adapter: Driver specific private structue

s/structue/structure/

> + *
> + * Extended remove logic which will be used for
> + * hard reset as well
> + */

...