Subject: Re: [Intel-wired-lan] [PATCH net-next 09/15] idpf: initialize interrupts and enable vport

From: Simon Horman <[email-masked]>
Date: Fri, 31 Mar 2023 17:59:37 +0200

On Wed, Mar 29, 2023 at 07:03:58AM -0700, Pavan Kumar Linga wrote:
> To further continue 'vport open', initialize all the resources
> required for the interrupts. To start with, initialize the
> queue vector indices with the ones received from the device
> Control Plane. Now that all the TX and RX queues are initialized,
> map the RX descriptor and buffer queues as well as TX completion
> queues to the allocated vectors. Initialize and enable the napi
> handler for the napi polling. Finally, request the IRQs for the
> interrupt vectors from the stack and setup the interrupt handler.
> 
> Once the interrupt init is done, send 'map queue vector', 'enable
> queues' and 'enable vport' virtchnl messages to the CP to complete
> the 'vport open' flow.
> 
> Co-developed-by: Alan Brady <[email-masked]>
> Signed-off-by: Alan Brady <[email-masked]>
> Co-developed-by: Joshua Hay <[email-masked]>
> Signed-off-by: Joshua Hay <[email-masked]>
> Co-developed-by: Madhu Chittim <[email-masked]>
> Signed-off-by: Madhu Chittim <[email-masked]>
> Co-developed-by: Phani Burra <[email-masked]>
> Signed-off-by: Phani Burra <[email-masked]>
> Signed-off-by: Pavan Kumar Linga <[email-masked]>
> Reviewed-by: Sridhar Samudrala <[email-masked]>

Spelling from me again.
I think I'll stop there and just mention that you might want to consider
adding ./checkpatch.pl --codespell to your CI.

> diff --git a/drivers/net/ethernet/intel/idpf/idpf_lib.c b/drivers/net/ethernet/intel/idpf/idpf_lib.c

...

> +/**
> + * idpf_up_complete - Complete interface up sequence
> + * @vport: virtual port strucutre
> + *
> + * Returns 0 on success, negative on failure.
> + */

s/strucutre/structure/

...