Subject: Re: [PATCH net-next 2/4] ice: remove redundant Rx field from rule info

From: Simon Horman <[email-masked]>
Date: Sat, 1 Apr 2023 11:03:26 +0200

On Fri, Mar 31, 2023 at 12:57:45PM +0200, Michal Swiatkowski wrote:
> Information about the direction is currently stored in sw_act.flag.
> There is no need to duplicate it in another field.
> 
> Setting direction flag doesn't mean that there is a match criteria for
> direction in rule. It is only a information for HW from where switch id
> should be collected (VSI or port). In current implementation of advance
> rule handling, without matching for direction metadata, we can always
> set one the same flag and everything will work the same.
> 
> Ability to match on direction matadata will be added in follow up
> patches.

nit: checkpatch.pl --codespell tells me that 'matadata' is misspelt

> 
> Recipe 0, 3 and 9 loaded from package has direction match
> criteria, but they are handled in other function.
> 
> Signed-off-by: Michal Swiatkowski <[email-masked]>
> Reviewed-by: Piotr Raczynski <[email-masked]>

Reviewed-by: Simon Horman <[email-masked]>