Subject: Re: [PATCH 1/8] net: netronome: constify pointers to hwmon_channel_info

From: Simon Horman <[email-masked]>
Date: Fri, 7 Apr 2023 18:07:46 +0200

On Fri, Apr 07, 2023 at 04:59:04PM +0200, Krzysztof Kozlowski wrote:
> Statically allocated array of pointed to hwmon_channel_info can be made
> const for safety.
> 
> Signed-off-by: Krzysztof Kozlowski <[email-masked]>
> 
> ---
> 
> This depends on hwmon core patch:
> https://lore.kernel.org/all/[email-masked]/
> 
> Therefore I propose this should also go via hwmon tree.
> 
> Cc: Jean Delvare <[email-masked]>
> Cc: Guenter Roeck <[email-masked]>
> Cc: [email-masked]

Subject prefix should be 'nfp: '

Other than that, this looks ok to me.
Though I am at a loss as to what tree the patches at the URL above apply to
and thus am unable to verify this code in any way other than visually.

> ---
>  drivers/net/ethernet/netronome/nfp/nfp_hwmon.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/netronome/nfp/nfp_hwmon.c b/drivers/net/ethernet/netronome/nfp/nfp_hwmon.c
> index 5cabb1aa9c0c..0d6c59d6d4ae 100644
> --- a/drivers/net/ethernet/netronome/nfp/nfp_hwmon.c
> +++ b/drivers/net/ethernet/netronome/nfp/nfp_hwmon.c
> @@ -115,7 +115,7 @@ static const struct hwmon_channel_info nfp_power = {
>  	.config = nfp_power_config,
>  };
>  
> -static const struct hwmon_channel_info *nfp_hwmon_info[] = {
> +static const struct hwmon_channel_info * const nfp_hwmon_info[] = {
>  	&nfp_chip,
>  	&nfp_temp,
>  	&nfp_power,
> -- 
> 2.34.1
>