From: Simon Horman <simon.horman@corigine•com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro•org>
Cc: "Igor Russkikh" <irusskikh@marvell•com>,
"David S. Miller" <davem@davemloft•net>,
"Eric Dumazet" <edumazet@google•com>,
"Jakub Kicinski" <kuba@kernel•org>,
"Paolo Abeni" <pabeni@redhat•com>, "Andrew Lunn" <andrew@lunn•ch>,
"Heiner Kallweit" <hkallweit1@gmail•com>,
"Russell King" <linux@armlinux•org.uk>,
"Florian Fainelli" <f.fainelli@gmail•com>,
"Broadcom internal kernel review list"
<bcm-kernel-feedback-list@broadcom•com>,
"Marek Behún" <kabel@kernel•org>, "Xu Liang" <lxu@maxlinear•com>,
netdev@vger•kernel.org, linux-kernel@vger•kernel.org,
oss-drivers@corigine•com, "Jean Delvare" <jdelvare@suse•com>,
"Guenter Roeck" <linux@roeck-us•net>,
linux-hwmon@vger•kernel.org
Subject: Re: [PATCH 1/8] net: netronome: constify pointers to hwmon_channel_info
Date: Fri, 7 Apr 2023 20:17:37 +0200 [thread overview]
Message-ID: <ZDBeQam3wj7ZHodC@corigine.com> (raw)
In-Reply-To: <ZDA/0qvfO1qHMoEJ@corigine.com>
On Fri, Apr 07, 2023 at 06:07:56PM +0200, Simon Horman wrote:
> On Fri, Apr 07, 2023 at 04:59:04PM +0200, Krzysztof Kozlowski wrote:
> > Statically allocated array of pointed to hwmon_channel_info can be made
> > const for safety.
> >
> > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro•org>
> >
> > ---
> >
> > This depends on hwmon core patch:
> > https://lore.kernel.org/all/20230406203103.3011503-2-krzysztof.kozlowski@linaro.org/
> >
> > Therefore I propose this should also go via hwmon tree.
> >
> > Cc: Jean Delvare <jdelvare@suse•com>
> > Cc: Guenter Roeck <linux@roeck-us•net>
> > Cc: linux-hwmon@vger•kernel.org
>
> Subject prefix should be 'nfp: '
>
> Other than that, this looks ok to me.
> Though I am at a loss as to what tree the patches at the URL above apply to
> and thus am unable to verify this code in any way other than visually.
I've now been able to apply and build the patch on top of
git://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git hwmon-const
Thanks to Guenter for supplying the branch.
And thanks to Krzysztof for the patch.
My nit about the subject prefix not withstanding,
Acked-by: Simon Horman <simon.horman@corigine•com>
next prev parent reply other threads:[~2023-04-07 18:17 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-07 14:59 [PATCH 1/8] net: netronome: constify pointers to hwmon_channel_info Krzysztof Kozlowski
2023-04-07 14:59 ` [PATCH 2/8] net: aquantia: " Krzysztof Kozlowski
2023-04-07 14:59 ` [PATCH 3/8] net: phy: " Krzysztof Kozlowski
2023-04-07 15:04 ` Andrew Lunn
2023-04-07 14:59 ` [PATCH 4/8] net: phy: bcm54140: " Krzysztof Kozlowski
2023-04-07 15:04 ` Andrew Lunn
2023-04-07 14:59 ` [PATCH 5/8] net: phy: marvell: " Krzysztof Kozlowski
2023-04-07 15:04 ` Andrew Lunn
2023-04-07 14:59 ` [PATCH 6/8] net: phy: mxl: " Krzysztof Kozlowski
2023-04-07 15:05 ` Andrew Lunn
2023-04-07 14:59 ` [PATCH 7/8] net: phy: nxp-tja11xx: " Krzysztof Kozlowski
2023-04-07 15:05 ` Andrew Lunn
2023-04-07 14:59 ` [PATCH 8/8] net: phy: sfp: " Krzysztof Kozlowski
2023-04-07 15:05 ` Andrew Lunn
2023-04-07 15:47 ` [PATCH 1/8] net: netronome: " Jakub Kicinski
2023-04-07 18:05 ` Guenter Roeck
2023-04-08 1:10 ` Jakub Kicinski
2023-04-08 10:44 ` Krzysztof Kozlowski
2023-04-07 16:07 ` Simon Horman
2023-04-07 18:17 ` Simon Horman [this message]
2023-04-07 23:07 ` Guenter Roeck
2023-04-10 2:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZDBeQam3wj7ZHodC@corigine.com \
--to=simon.horman@corigine$(echo .)com \
--cc=andrew@lunn$(echo .)ch \
--cc=bcm-kernel-feedback-list@broadcom$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=f.fainelli@gmail$(echo .)com \
--cc=hkallweit1@gmail$(echo .)com \
--cc=irusskikh@marvell$(echo .)com \
--cc=jdelvare@suse$(echo .)com \
--cc=kabel@kernel$(echo .)org \
--cc=krzysztof.kozlowski@linaro$(echo .)org \
--cc=kuba@kernel$(echo .)org \
--cc=linux-hwmon@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux@armlinux$(echo .)org.uk \
--cc=linux@roeck-us$(echo .)net \
--cc=lxu@maxlinear$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=oss-drivers@corigine$(echo .)com \
--cc=pabeni@redhat$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox