From: Simon Horman <simon.horman@corigine•com>
To: Brett Creeley <brett.creeley@amd•com>
Cc: davem@davemloft•net, netdev@vger•kernel.org, kuba@kernel•org,
drivers@pensando•io, shannon.nelson@amd•com, allen.hubbe@amd•com
Subject: Re: [PATCH net-next] ionic: Don't overwrite the cyclecounter bitmask
Date: Sat, 8 Apr 2023 15:32:03 +0200 [thread overview]
Message-ID: <ZDFs0wYQCaHTLCDq@corigine.com> (raw)
In-Reply-To: <20230407184539.27559-1-brett.creeley@amd.com>
On Fri, Apr 07, 2023 at 11:45:39AM -0700, Brett Creeley wrote:
> The driver was incorrectly overwriting the cyclecounter bitmask,
> which was truncating it and not aligning to the hardware mask value.
> This isn't causing any issues, but it's wrong. Fix this by not
> constraining the cyclecounter/hardware mask.
>
> Luckily, this seems to cause no issues, which is why this change
> doesn't have a fixes tag and isn't being sent to net. However, if
> any transformations from time->cycles are needed in the future,
> this change will be needed.
>
> Suggested-by: Allen Hubbe <allen.hubbe@amd•com>
> Signed-off-by: Brett Creeley <brett.creeley@amd•com>
> Signed-off-by: Shannon Nelson <shannon.nelson@amd•com>
Reviewed-by: Simon Horman <simon.horman@corigine•com>
next prev parent reply other threads:[~2023-04-08 13:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-07 18:45 [PATCH net-next] ionic: Don't overwrite the cyclecounter bitmask Brett Creeley
2023-04-08 13:32 ` Simon Horman [this message]
2023-04-12 8:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZDFs0wYQCaHTLCDq@corigine.com \
--to=simon.horman@corigine$(echo .)com \
--cc=allen.hubbe@amd$(echo .)com \
--cc=brett.creeley@amd$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=drivers@pensando$(echo .)io \
--cc=kuba@kernel$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=shannon.nelson@amd$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox