From: Christoph Hellwig <hch@infradead•org>
To: Xuan Zhuo <xuanzhuo@linux•alibaba.com>
Cc: virtualization@lists•linux-foundation.org,
"Michael S. Tsirkin" <mst@redhat•com>,
Jason Wang <jasowang@redhat•com>,
Alexei Starovoitov <ast@kernel•org>,
Daniel Borkmann <daniel@iogearbox•net>,
"David S. Miller" <davem@davemloft•net>,
Jesper Dangaard Brouer <hawk@kernel•org>,
John Fastabend <john.fastabend@gmail•com>,
netdev@vger•kernel.org, bpf@vger•kernel.org,
Christoph Hellwig <hch@infradead•org>,
Jakub Kicinski <kuba@kernel•org>,
Alexander Lobakin <aleksander.lobakin@intel•com>
Subject: Re: [PATCH vhost v7 01/11] virtio_ring: split: separate dma codes
Date: Sun, 30 Apr 2023 21:24:52 -0700 [thread overview]
Message-ID: <ZE8/FC4ONDLshya2@infradead.org> (raw)
In-Reply-To: <20230425073613.8839-2-xuanzhuo@linux.alibaba.com>
> +static dma_addr_t vring_sg_address(struct scatterlist *sg)
> +{
> + if (sg->dma_address)
> + return sg->dma_address;
0 is a perfectly valid DMA address. So I have no idea how this is
even supposed to work.
next prev parent reply other threads:[~2023-05-01 4:25 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-25 7:36 [PATCH vhost v7 00/11] virtio core prepares for AF_XDP Xuan Zhuo
2023-04-25 7:36 ` [PATCH vhost v7 01/11] virtio_ring: split: separate dma codes Xuan Zhuo
2023-05-01 4:24 ` Christoph Hellwig [this message]
2023-05-06 3:08 ` Xuan Zhuo
2023-04-25 7:36 ` [PATCH vhost v7 02/11] virtio_ring: packed: " Xuan Zhuo
2023-04-25 7:36 ` [PATCH vhost v7 03/11] virtio_ring: packed-indirect: " Xuan Zhuo
2023-04-25 7:36 ` [PATCH vhost v7 04/11] virtio_ring: split: support premapped Xuan Zhuo
2023-04-25 7:36 ` [PATCH vhost v7 05/11] virtio_ring: packed: " Xuan Zhuo
2023-04-25 7:36 ` [PATCH vhost v7 06/11] virtio_ring: packed-indirect: " Xuan Zhuo
2023-04-25 7:36 ` [PATCH vhost v7 07/11] virtio_ring: update document for virtqueue_add_* Xuan Zhuo
2023-04-25 7:36 ` [PATCH vhost v7 08/11] virtio_ring: introduce virtqueue_dma_dev() Xuan Zhuo
2023-04-25 7:36 ` [PATCH vhost v7 09/11] virtio_ring: correct the expression of the description of virtqueue_resize() Xuan Zhuo
2023-04-25 7:36 ` [PATCH vhost v7 10/11] virtio_ring: separate the logic of reset/enable from virtqueue_resize Xuan Zhuo
2023-04-25 7:36 ` [PATCH vhost v7 11/11] virtio_ring: introduce virtqueue_reset() Xuan Zhuo
2023-04-25 7:51 ` [PATCH vhost v7 00/11] virtio core prepares for AF_XDP Michael S. Tsirkin
2023-04-25 8:05 ` Xuan Zhuo
2023-04-25 8:13 ` Michael S. Tsirkin
2023-04-25 8:21 ` Xuan Zhuo
2023-04-25 12:40 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZE8/FC4ONDLshya2@infradead.org \
--to=hch@infradead$(echo .)org \
--cc=aleksander.lobakin@intel$(echo .)com \
--cc=ast@kernel$(echo .)org \
--cc=bpf@vger$(echo .)kernel.org \
--cc=daniel@iogearbox$(echo .)net \
--cc=davem@davemloft$(echo .)net \
--cc=hawk@kernel$(echo .)org \
--cc=jasowang@redhat$(echo .)com \
--cc=john.fastabend@gmail$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=mst@redhat$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=virtualization@lists$(echo .)linux-foundation.org \
--cc=xuanzhuo@linux$(echo .)alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox