From: Jason Gunthorpe <jgg@nvidia•com>
To: Lorenzo Stoakes <lstoakes@gmail•com>
Cc: Christoph Hellwig <hch@infradead•org>,
linux-mm@kvack•org, linux-kernel@vger•kernel.org,
Andrew Morton <akpm@linux-foundation•org>,
Jens Axboe <axboe@kernel•dk>,
Matthew Wilcox <willy@infradead•org>,
Dennis Dalessandro <dennis.dalessandro@cornelisnetworks•com>,
Leon Romanovsky <leon@kernel•org>,
Christian Benvenuti <benve@cisco•com>,
Nelson Escobar <neescoba@cisco•com>,
Bernard Metzler <bmt@zurich•ibm.com>,
Peter Zijlstra <peterz@infradead•org>,
Ingo Molnar <mingo@redhat•com>,
Arnaldo Carvalho de Melo <acme@kernel•org>,
Mark Rutland <mark.rutland@arm•com>,
Alexander Shishkin <alexander.shishkin@linux•intel.com>,
Jiri Olsa <jolsa@kernel•org>, Namhyung Kim <namhyung@kernel•org>,
Ian Rogers <irogers@google•com>,
Adrian Hunter <adrian.hunter@intel•com>,
Bjorn Topel <bjorn@kernel•org>,
Magnus Karlsson <magnus.karlsson@intel•com>,
Maciej Fijalkowski <maciej.fijalkowski@intel•com>,
Jonathan Lemon <jonathan.lemon@gmail•com>,
"David S . Miller" <davem@davemloft•net>,
Eric Dumazet <edumazet@google•com>,
Jakub Kicinski <kuba@kernel•org>, Paolo Abeni <pabeni@redhat•com>,
Christian Brauner <brauner@kernel•org>,
Richard Cochran <richardcochran@gmail•com>,
Alexei Starovoitov <ast@kernel•org>,
Daniel Borkmann <daniel@iogearbox•net>,
Jesper Dangaard Brouer <hawk@kernel•org>,
John Fastabend <john.fastabend@gmail•com>,
linux-fsdevel@vger•kernel.org, linux-perf-users@vger•kernel.org,
netdev@vger•kernel.org, bpf@vger•kernel.org,
Oleg Nesterov <oleg@redhat•com>
Subject: Re: [PATCH v2] mm/gup: disallow GUP writing to file-backed mappings by default
Date: Mon, 24 Apr 2023 20:17:11 -0300 [thread overview]
Message-ID: <ZEcN92iJoe+3ANVc@nvidia.com> (raw)
In-Reply-To: <4f16b1fc-6bc5-4e41-8e94-151c336fcf69@lucifer.local>
On Tue, Apr 25, 2023 at 12:03:34AM +0100, Lorenzo Stoakes wrote:
> Except you dirty a page that is mapped elsewhere that thought everything
> was cleaned and... not sure the PTLs really help you much?
If we have a writable PTE then while the PTE's PTL is held it is impossible
for a FS to make the page clean as any cleaning action has to also
take the PTL to make the PTE non-present or non-writable.
> If we want to be more adventerous the opt-in variant could default to on
> for FOLL_LONGTERM too, but that discussion can be had over on that patch
> series.
I think you should at least do this too to explain why io_uring code
is moving into common code..
Jason
next prev parent reply other threads:[~2023-04-24 23:19 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-24 7:43 [PATCH v2] mm/gup: disallow GUP writing to file-backed mappings by default Lorenzo Stoakes
2023-04-24 9:43 ` Christoph Hellwig
2023-04-24 10:17 ` Lorenzo Stoakes
2023-04-24 12:28 ` Jason Gunthorpe
2023-04-24 12:38 ` Christoph Hellwig
2023-04-24 13:26 ` Jason Gunthorpe
2023-04-24 12:38 ` Lorenzo Stoakes
2023-04-24 13:39 ` Jason Gunthorpe
2023-04-24 14:29 ` Lorenzo Stoakes
2023-04-24 17:36 ` Jason Gunthorpe
2023-04-24 18:22 ` Lorenzo Stoakes
2023-04-24 18:54 ` Jason Gunthorpe
2023-04-24 19:18 ` Lorenzo Stoakes
2023-04-24 22:53 ` Jason Gunthorpe
2023-04-24 23:03 ` Lorenzo Stoakes
2023-04-24 23:17 ` Jason Gunthorpe [this message]
2023-04-24 23:26 ` Lorenzo Stoakes
2023-04-24 23:30 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZEcN92iJoe+3ANVc@nvidia.com \
--to=jgg@nvidia$(echo .)com \
--cc=acme@kernel$(echo .)org \
--cc=adrian.hunter@intel$(echo .)com \
--cc=akpm@linux-foundation$(echo .)org \
--cc=alexander.shishkin@linux$(echo .)intel.com \
--cc=ast@kernel$(echo .)org \
--cc=axboe@kernel$(echo .)dk \
--cc=benve@cisco$(echo .)com \
--cc=bjorn@kernel$(echo .)org \
--cc=bmt@zurich$(echo .)ibm.com \
--cc=bpf@vger$(echo .)kernel.org \
--cc=brauner@kernel$(echo .)org \
--cc=daniel@iogearbox$(echo .)net \
--cc=davem@davemloft$(echo .)net \
--cc=dennis.dalessandro@cornelisnetworks$(echo .)com \
--cc=edumazet@google$(echo .)com \
--cc=hawk@kernel$(echo .)org \
--cc=hch@infradead$(echo .)org \
--cc=irogers@google$(echo .)com \
--cc=john.fastabend@gmail$(echo .)com \
--cc=jolsa@kernel$(echo .)org \
--cc=jonathan.lemon@gmail$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=leon@kernel$(echo .)org \
--cc=linux-fsdevel@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-mm@kvack$(echo .)org \
--cc=linux-perf-users@vger$(echo .)kernel.org \
--cc=lstoakes@gmail$(echo .)com \
--cc=maciej.fijalkowski@intel$(echo .)com \
--cc=magnus.karlsson@intel$(echo .)com \
--cc=mark.rutland@arm$(echo .)com \
--cc=mingo@redhat$(echo .)com \
--cc=namhyung@kernel$(echo .)org \
--cc=neescoba@cisco$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=oleg@redhat$(echo .)com \
--cc=pabeni@redhat$(echo .)com \
--cc=peterz@infradead$(echo .)org \
--cc=richardcochran@gmail$(echo .)com \
--cc=willy@infradead$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox