Subject: Re: [PATCH] ipvlan: Remove NULL check before dev_{put, hold}

From: Simon Horman <[email-masked]>
Date: Fri, 12 May 2023 16:08:36 +0200

On Thu, May 11, 2023 at 08:54:53AM -0700, Stephen Hemminger wrote:
> On Thu, 11 May 2023 15:21:19 +0800
> Yang Li <[email-masked]> wrote:
> 
> > The call netdev_{put, hold} of dev_{put, hold} will check NULL,
> > so there is no need to check before using dev_{put, hold},
> > remove it to silence the warning:
> > 
> > ./drivers/net/ipvlan/ipvlan_core.c:559:3-11: WARNING: NULL check before dev_{put, hold} functions is not needed.
> > 
> > Reported-by: Abaci Robot <[email-masked]>
> > Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=4930
> > Signed-off-by: Yang Li <[email-masked]>
> 
> Maybe add new coccinelle script for this? scripts/free/dev_hold.cocci?

FWIIW, I observe that Coccinelle flags this problem as per the log above.
But perhaps I am missing your point.