Subject: Re: [RFC PATCH v7 2/8] dpll: Add DPLL framework base functions

From: Jiri Pirko <[email-masked]>
Date: Thu, 4 May 2023 13:18:49 +0200

Fri, Apr 28, 2023 at 02:20:03AM CEST, [email-masked] wrote:

[...]

>diff --git a/include/uapi/linux/dpll.h b/include/uapi/linux/dpll.h
>index e188bc189754..75eeaa4396eb 100644
>--- a/include/uapi/linux/dpll.h
>+++ b/include/uapi/linux/dpll.h
>@@ -111,6 +111,8 @@ enum dpll_pin_direction {
> 
> #define DPLL_PIN_FREQUENCY_1_HZ		1
> #define DPLL_PIN_FREQUENCY_10_MHZ	10000000
>+#define DPLL_PIN_FREQUENCY_10_KHZ	10000
>+#define DPLL_PIN_FREQUENCY_77_5_KHZ	77500

This should be moved to patch #1.
please convert to enum, could be unnamed.

[...]