From: Simon Horman <simon.horman@corigine•com>
To: Tony Nguyen <anthony.l.nguyen@intel•com>
Cc: davem@davemloft•net, kuba@kernel•org, pabeni@redhat•com,
edumazet@google•com, netdev@vger•kernel.org,
Jan Sokolowski <jan.sokolowski@intel•com>,
maciej.fijalkowski@intel•com, daniel@iogearbox•net,
Alexander Lobakin <aleksander.lobakin@intel•com>,
Michal Schmidt <mschmidt@redhat•com>,
Pucha Himasekhar Reddy <himasekharx.reddy.pucha@intel•com>
Subject: Re: [PATCH net] ice: Fix undersized tx_flags variable
Date: Mon, 8 May 2023 21:08:22 +0200 [thread overview]
Message-ID: <ZFlIpsd+nQ7x1pjU@corigine.com> (raw)
In-Reply-To: <20230508174225.1707403-1-anthony.l.nguyen@intel.com>
On Mon, May 08, 2023 at 10:42:25AM -0700, Tony Nguyen wrote:
> From: Jan Sokolowski <jan.sokolowski@intel•com>
>
> As not all ICE_TX_FLAGS_* fit in current 16-bit limited
> tx_flags field, some VLAN-related flags would not properly apply.
>
> Fix that by refactoring tx_flags variable into flags only and
> a separate variable that holds VLAN ID. As there is some space left,
> type variable can fit between those two. Pahole reports no size
> change to ice_tx_buf struct.
>
> Fixes: aa1d3faf71a6 ("ice: Robustify cleaning/completing XDP Tx buffers")
> Signed-off-by: Jan Sokolowski <jan.sokolowski@intel•com>
> Reviewed-by: Alexander Lobakin <aleksander.lobakin@intel•com>
> Tested-by: Michal Schmidt <mschmidt@redhat•com>
> Tested-by: Pucha Himasekhar Reddy <himasekharx.reddy.pucha@intel•com> (A Contingent worker at Intel)
> Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel•com>
Reviewed-by: Simon Horman <simon.horman@corigine•com>
next prev parent reply other threads:[~2023-05-08 19:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-08 17:42 [PATCH net] ice: Fix undersized tx_flags variable Tony Nguyen
2023-05-08 19:08 ` Simon Horman [this message]
2023-05-10 3:09 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZFlIpsd+nQ7x1pjU@corigine.com \
--to=simon.horman@corigine$(echo .)com \
--cc=aleksander.lobakin@intel$(echo .)com \
--cc=anthony.l.nguyen@intel$(echo .)com \
--cc=daniel@iogearbox$(echo .)net \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=himasekharx.reddy.pucha@intel$(echo .)com \
--cc=jan.sokolowski@intel$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=maciej.fijalkowski@intel$(echo .)com \
--cc=mschmidt@redhat$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox