From: Simon Horman <simon.horman@corigine•com>
To: Siddharth Vadapalli <s-vadapalli@ti•com>
Cc: andrew@lunn•ch, hkallweit1@gmail•com, linux@armlinux•org.uk,
davem@davemloft•net, edumazet@google•com, kuba@kernel•org,
pabeni@redhat•com, netdev@vger•kernel.org,
linux-kernel@vger•kernel.org,
linux-arm-kernel@lists•infradead.org, srk@ti•com
Subject: Re: [PATCH net v3] net: phy: dp83867: add w/a for packet errors seen with short cables
Date: Thu, 11 May 2023 12:07:06 +0200 [thread overview]
Message-ID: <ZFy+SnPWIn8aBRxg@corigine.com> (raw)
In-Reply-To: <20230510125139.646222-1-s-vadapalli@ti.com>
On Wed, May 10, 2023 at 06:21:39PM +0530, Siddharth Vadapalli wrote:
> From: Grygorii Strashko <grygorii.strashko@ti•com>
>
> Introduce the W/A for packet errors seen with short cables (<1m) between
> two DP83867 PHYs.
>
> The W/A recommended by DM requires FFE Equalizer Configuration tuning by
> writing value 0x0E81 to DSP_FFE_CFG register (0x012C), surrounded by hard
> and soft resets as follows:
>
> write_reg(0x001F, 0x8000); //hard reset
> write_reg(DSP_FFE_CFG, 0x0E81);
> write_reg(0x001F, 0x4000); //soft reset
>
> Since DP83867 PHY DM says "Changing this register to 0x0E81, will not
> affect Long Cable performance.", enable the W/A by default.
>
> Fixes: 2a10154abcb7 ("net: phy: dp83867: Add TI dp83867 phy")
> Signed-off-by: Grygorii Strashko <grygorii.strashko@ti•com>
> Signed-off-by: Siddharth Vadapalli <s-vadapalli@ti•com>
Reviewed-by: Simon Horman <simon.horman@corigine•com>
next prev parent reply other threads:[~2023-05-11 10:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-10 12:51 [PATCH net v3] net: phy: dp83867: add w/a for packet errors seen with short cables Siddharth Vadapalli
2023-05-11 10:07 ` Simon Horman [this message]
2023-05-12 7:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZFy+SnPWIn8aBRxg@corigine.com \
--to=simon.horman@corigine$(echo .)com \
--cc=andrew@lunn$(echo .)ch \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=hkallweit1@gmail$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux@armlinux$(echo .)org.uk \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=s-vadapalli@ti$(echo .)com \
--cc=srk@ti$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox