From: Simon Horman <simon.horman@corigine•com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix•de>
Cc: Byungho An <bh74.an@samsung•com>,
netdev@vger•kernel.org, Eric Dumazet <edumazet@google•com>,
kernel@pengutronix•de, Jakub Kicinski <kuba@kernel•org>,
Paolo Abeni <pabeni@redhat•com>,
"David S. Miller" <davem@davemloft•net>
Subject: Re: [PATCH net-next] net: samsung: sxgbe: Make sxgbe_drv_remove() return void
Date: Thu, 11 May 2023 12:51:24 +0200 [thread overview]
Message-ID: <ZFzIrLxLXwKdemyE@corigine.com> (raw)
In-Reply-To: <20230511104509.wllidoba775bldms@pengutronix.de>
On Thu, May 11, 2023 at 12:45:09PM +0200, Uwe Kleine-König wrote:
> On Thu, May 11, 2023 at 12:28:54PM +0200, Simon Horman wrote:
> > On Thu, May 11, 2023 at 12:17:40PM +0200, Simon Horman wrote:
> > > On Wed, May 10, 2023 at 10:02:47PM +0200, Uwe Kleine-König wrote:
> > > > sxgbe_drv_remove() returned zero unconditionally, so it can be converted
> > > > to return void without losing anything. The upside is that it becomes
> > > > more obvious in its callers that there is no error to handle.
> > > >
> > > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix•de>
> > >
> > > Reviewed-by: Simon Horman <simon.horman@corigine•com>
> >
> > Sorry, minor nit.
> > Perhaps the subject prefix should be 'net: sxgbe: ', for consistency.
> > Or 'sxgbe: ' because the 'net: ' part is largely meaningless.
>
> I'd not drop "net:". Looking at the output of
>
> git log --format=%s next/master -- drivers/net/ethernet/samsung/sxgbe/ | sed 's/:[^:]*$//' | sort | uniq -c | sort -n
>
> the clear winner is "net: sxgbe: ".
>
> If and when I will resend this patch, I'll adapt accordingly. If it's
> taken as is (or the committer adapts the subject line) that's fine for
> me, too.
Thanks, that's good for me on all counts.
next prev parent reply other threads:[~2023-05-11 10:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-10 20:02 [PATCH net-next] net: samsung: sxgbe: Make sxgbe_drv_remove() return void Uwe Kleine-König
2023-05-11 10:17 ` Simon Horman
2023-05-11 10:28 ` Simon Horman
2023-05-11 10:45 ` Uwe Kleine-König
2023-05-11 10:51 ` Simon Horman [this message]
2023-05-12 8:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZFzIrLxLXwKdemyE@corigine.com \
--to=simon.horman@corigine$(echo .)com \
--cc=bh74.an@samsung$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=kernel@pengutronix$(echo .)de \
--cc=kuba@kernel$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=u.kleine-koenig@pengutronix$(echo .)de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox