From: "Russell King (Oracle)" <linux@armlinux•org.uk>
To: Paolo Abeni <pabeni@redhat•com>
Cc: Andrew Lunn <andrew@lunn•ch>,
Heiner Kallweit <hkallweit1@gmail•com>,
Andy Shevchenko <andy.shevchenko@gmail•com>,
"David S. Miller" <davem@davemloft•net>,
Eric Dumazet <edumazet@google•com>,
Jakub Kicinski <kuba@kernel•org>,
netdev@vger•kernel.org
Subject: Re: [PATCH net-next] net: phylink: constify fwnode arguments
Date: Thu, 11 May 2023 12:32:37 +0100 [thread overview]
Message-ID: <ZFzSVciEsAU/pKLB@shell.armlinux.org.uk> (raw)
In-Reply-To: <75dd5f74abe1d168e9bb679d1e47947f4900a1f9.camel@redhat.com>
On Thu, May 11, 2023 at 01:29:50PM +0200, Paolo Abeni wrote:
> On Wed, 2023-05-10 at 12:03 +0100, Russell King (Oracle) wrote:
> > diff --git a/include/linux/phylink.h b/include/linux/phylink.h
> > index 71755c66c162..02c777ad18f2 100644
> > --- a/include/linux/phylink.h
> > +++ b/include/linux/phylink.h
> > @@ -568,7 +568,8 @@ void phylink_generic_validate(struct phylink_config *config,
> > unsigned long *supported,
> > struct phylink_link_state *state);
> >
> > -struct phylink *phylink_create(struct phylink_config *, struct fwnode_handle *,
> > +struct phylink *phylink_create(struct phylink_config *,
> > + const struct fwnode_handle *,
>
> While touching the above, could you please also add the missing params
> name, to keep checkpatch happy and be consistent with the others
> arguments?
For interest, when did naming parameters in a prototype become a
requirement?
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2023-05-11 11:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-10 11:03 [PATCH net-next] net: phylink: constify fwnode arguments Russell King (Oracle)
2023-05-10 11:42 ` Simon Horman
2023-05-10 13:59 ` Andy Shevchenko
2023-05-11 11:29 ` Paolo Abeni
2023-05-11 11:32 ` Russell King (Oracle) [this message]
2023-05-11 13:47 ` Paolo Abeni
2023-05-11 15:31 ` Russell King (Oracle)
-- strict thread matches above, loose matches on Subject: below --
2023-05-12 16:58 Russell King (Oracle)
2023-05-13 20:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZFzSVciEsAU/pKLB@shell.armlinux.org.uk \
--to=linux@armlinux$(echo .)org.uk \
--cc=andrew@lunn$(echo .)ch \
--cc=andy.shevchenko@gmail$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=hkallweit1@gmail$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox