Subject: Re: DP83867 ethernet PHY regression

From: Bagas Sanjaya <[email-masked]>
Date: Wed, 24 May 2023 19:51:20 +0700

On Mon, May 22, 2023 at 04:58:46PM +0200, Francesco Dolcini wrote:
> Hello all,
> commit da9ef50f545f ("net: phy: dp83867: perform soft reset and retain
> established link") introduces a regression on my TI AM62 based board.
> 
> I have a working DTS with Linux TI 5.10 downstream kernel branch, while
> testing the DTS with v6.4-rc in preparation of sending it to the mailing
> list I noticed that ethernet is working only on a cold poweron.
> 
> With da9ef50f545f reverted it always works.
> 
> Here the DTS snippet for reference:
> 
> &cpsw_port1 {
> 	phy-handle = <&cpsw3g_phy0>;
> 	phy-mode = "rgmii-rxid";
> };
> 
> &cpsw3g_mdio {
> 	assigned-clocks = <&k3_clks 157 20>;
> 	assigned-clock-parents = <&k3_clks 157 22>;
> 	assigned-clock-rates = <25000000>;
> 
> 	cpsw3g_phy0: ethernet-phy@0 {
> 		compatible = "ethernet-phy-id2000.a231";
> 		reg = <0>;
> 		interrupt-parent = <&main_gpio0>;
> 		interrupts = <25 IRQ_TYPE_EDGE_FALLING>;
> 		reset-gpios = <&main_gpio0 17 GPIO_ACTIVE_LOW>;
> 		reset-assert-us = <10>;
> 		reset-deassert-us = <1000>;
> 		ti,fifo-depth = <DP83867_PHYCR_FIFO_DEPTH_4_B_NIB>;
> 		ti,rx-internal-delay = <DP83867_RGMIIDCTL_2_00_NS>;
> 	};
> };
> 

Thanks for the regression report. I'm adding it to regzbot:

#regzbot ^introduced: da9ef50f545f86
#regzbot title: TI AM62 DTS regression due to dp83867 soft reset

-- 
An old man doll... just what I always wanted! - Clara