Subject: Re: [PATCH net] amd-xgbe: fix the false linkup in xgbe_phy_status

From: Simon Horman <[email-masked]>
Date: Thu, 25 May 2023 10:40:02 +0200

On Wed, May 24, 2023 at 11:19:02PM +0530, Raju Rangoju wrote:
> In the event of a change in XGBE mode, the current auto-negotiation
> needs to be reset and the AN cycle needs to be re-triggerred. However,
> the current code ignores the return value of xgbe_set_mode(), leading to
> false information as the link is declared without checking the status
> register.
> 
> Fix this by propogating the mode switch status information to

nit: s/propogating/propagating/

     It's probably not worth respinning this patch just to fix spelling.
     But please do consider running checkpatch --codespell

> xgbe_phy_status().
> 
> Fixes: e57f7a3feaef ("amd-xgbe: Prepare for working with more than one type of phy")
> Co-developed-by: Sudheesh Mavila <[email-masked]>
> Signed-off-by: Sudheesh Mavila <[email-masked]>
> Signed-off-by: Raju Rangoju <[email-masked]>

The above nit notwithstanding,

Reviewed-by: Simon Horman <[email-masked]>