Subject: Re: [PATCH] wifi: mt76: mt7915: add support for MT7981

From: Simon Horman <[email-masked]>
Date: Sun, 14 May 2023 16:53:43 +0200

On Sat, May 13, 2023 at 03:35:51PM +0200, Daniel Golle wrote:
> From: Alexander Couzens <[email-masked]>
> 
> Add support for the MediaTek MT7981 SoC which is similar to the MT7986
> but with a newer IP cores and only 2x ARM Cortex-A53 instead of 4x.
> Unlike MT7986 the MT7981 can only connect a single wireless frontend,
> usually MT7976 is used for DBDC.
> 
> Signed-off-by: Alexander Couzens <[email-masked]>
> Signed-off-by: Daniel Golle <[email-masked]>

...

> @@ -489,7 +516,10 @@ static int mt7986_wmac_adie_patch_7976(struct mt7915_dev *dev, u8 adie)
>  		rg_xo_01 = 0x1d59080f;
>  		rg_xo_03 = 0x34c00fe0;
>  	} else {
> -		rg_xo_01 = 0x1959f80f;
> +		if (is_mt7981(&dev->mt76))
> +			rg_xo_01 = 0x1959c80f;
> +		else if (is_mt7986(&dev->mt76))
> +			rg_xo_01 = 0x1959f80f;

Hi Daniel,

		rg_xo_01 will be used uninitialised below if we get here
		and neither of the conditions above are true.

		Can this occur?

>  		rg_xo_03 = 0x34d00fe0;
>  	}

...