From: Christoph Hellwig <hch@infradead•org>
To: Lorenzo Stoakes <lstoakes@gmail•com>
Cc: Christoph Hellwig <hch@infradead•org>, Jan Kara <jack@suse•cz>,
Jason Gunthorpe <jgg@nvidia•com>,
"Kirill A . Shutemov" <kirill@shutemov•name>,
linux-mm@kvack•org, linux-kernel@vger•kernel.org,
Andrew Morton <akpm@linux-foundation•org>,
Jens Axboe <axboe@kernel•dk>,
Matthew Wilcox <willy@infradead•org>,
Dennis Dalessandro <dennis.dalessandro@cornelisnetworks•com>,
Leon Romanovsky <leon@kernel•org>,
Christian Benvenuti <benve@cisco•com>,
Nelson Escobar <neescoba@cisco•com>,
Bernard Metzler <bmt@zurich•ibm.com>,
Peter Zijlstra <peterz@infradead•org>,
Ingo Molnar <mingo@redhat•com>,
Arnaldo Carvalho de Melo <acme@kernel•org>,
Mark Rutland <mark.rutland@arm•com>,
Alexander Shishkin <alexander.shishkin@linux•intel.com>,
Jiri Olsa <jolsa@kernel•org>, Namhyung Kim <namhyung@kernel•org>,
Ian Rogers <irogers@google•com>,
Adrian Hunter <adrian.hunter@intel•com>,
Bjorn Topel <bjorn@kernel•org>,
Magnus Karlsson <magnus.karlsson@intel•com>,
Maciej Fijalkowski <maciej.fijalkowski@intel•com>,
Jonathan Lemon <jonathan.lemon@gmail•com>,
"David S . Miller" <davem@davemloft•net>,
Eric Dumazet <edumazet@google•com>,
Jakub Kicinski <kuba@kernel•org>, Paolo Abeni <pabeni@redhat•com>,
Christian Brauner <brauner@kernel•org>,
Richard Cochran <richardcochran@gmail•com>,
Alexei Starovoitov <ast@kernel•org>,
Daniel Borkmann <daniel@iogearbox•net>,
Jesper Dangaard Brouer <hawk@kernel•org>,
John Fastabend <john.fastabend@gmail•com>,
linux-fsdevel@vger•kernel.org, linux-perf-users@vger•kernel.org,
netdev@vger•kernel.org, bpf@vger•kernel.org,
Oleg Nesterov <oleg@redhat•com>,
John Hubbard <jhubbard@nvidia•com>,
Pavel Begunkov <asml.silence@gmail•com>,
Mika Penttila <mpenttil@redhat•com>,
David Hildenbrand <david@redhat•com>,
Dave Chinner <david@fromorbit•com>, Theodore Ts'o <tytso@mit•edu>,
Peter Xu <peterx@redhat•com>,
Matthew Rosato <mjrosato@linux•ibm.com>,
"Paul E . McKenney" <paulmck@kernel•org>,
Christian Borntraeger <borntraeger@linux•ibm.com>
Subject: Re: [PATCH v9 0/3] mm/gup: disallow GUP writing to file-backed mappings by default
Date: Wed, 17 May 2023 01:10:17 -0700 [thread overview]
Message-ID: <ZGSL6Q8K5lh4Pdwp@infradead.org> (raw)
In-Reply-To: <503e92f9-fbc2-422b-b0d4-f4cabe3f6802@lucifer.local>
On Wed, May 17, 2023 at 08:55:27AM +0100, Lorenzo Stoakes wrote:
> I'll try to take this in good faith because... yeah. I do get that, I mean
> I literally created a repro for this situation and referenced in the commit
> msg and comments this precise problem in my patch series that
> addresses... this problem :P
>
> Perhaps I'm not being clear but it was simply my intent to highlight that
> yes this is the primary problem but ALSO GUP writing to ostensibly 'clean'
> pages 'behind the back' of a fs is _also_ a problem.
Yes, it absolutely is a problem if that happens. But we can just
fix it in the kernel using the:
lock_page()
copy data
set_page_dirty_locked()
unlock_page();
pattern, and we should have covere every place that did in tree.
But there's no good way to verify it except for regular code audits.
next prev parent reply other threads:[~2023-05-17 8:10 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-04 21:27 [PATCH v9 0/3] mm/gup: disallow GUP writing to file-backed mappings by default Lorenzo Stoakes
2023-05-04 21:27 ` [PATCH v9 1/3] mm/mmap: separate writenotify and dirty tracking logic Lorenzo Stoakes
2023-05-04 21:27 ` [PATCH v9 2/3] mm/gup: disallow FOLL_LONGTERM GUP-nonfast writing to file-backed mappings Lorenzo Stoakes
2023-05-04 21:27 ` [PATCH v9 3/3] mm/gup: disallow FOLL_LONGTERM GUP-fast " Lorenzo Stoakes
2023-05-05 20:21 ` [PATCH v9 0/3] mm/gup: disallow GUP writing to file-backed mappings by default David Hildenbrand
2023-05-05 21:12 ` Lorenzo Stoakes
2023-05-14 19:20 ` Lorenzo Stoakes
2023-05-15 5:14 ` Christoph Hellwig
2023-05-15 11:31 ` Lorenzo Stoakes
2023-05-17 8:26 ` David Hildenbrand
2023-05-15 11:03 ` Kirill A . Shutemov
2023-05-15 11:16 ` Lorenzo Stoakes
2023-05-15 12:12 ` Jason Gunthorpe
2023-05-15 13:07 ` Lorenzo Stoakes
2023-05-17 7:29 ` Jan Kara
2023-05-17 7:40 ` Lorenzo Stoakes
2023-05-17 7:43 ` Christoph Hellwig
2023-05-17 7:55 ` Lorenzo Stoakes
2023-05-17 8:10 ` Christoph Hellwig [this message]
2023-05-17 7:42 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZGSL6Q8K5lh4Pdwp@infradead.org \
--to=hch@infradead$(echo .)org \
--cc=acme@kernel$(echo .)org \
--cc=adrian.hunter@intel$(echo .)com \
--cc=akpm@linux-foundation$(echo .)org \
--cc=alexander.shishkin@linux$(echo .)intel.com \
--cc=asml.silence@gmail$(echo .)com \
--cc=ast@kernel$(echo .)org \
--cc=axboe@kernel$(echo .)dk \
--cc=benve@cisco$(echo .)com \
--cc=bjorn@kernel$(echo .)org \
--cc=bmt@zurich$(echo .)ibm.com \
--cc=borntraeger@linux$(echo .)ibm.com \
--cc=bpf@vger$(echo .)kernel.org \
--cc=brauner@kernel$(echo .)org \
--cc=daniel@iogearbox$(echo .)net \
--cc=davem@davemloft$(echo .)net \
--cc=david@fromorbit$(echo .)com \
--cc=david@redhat$(echo .)com \
--cc=dennis.dalessandro@cornelisnetworks$(echo .)com \
--cc=edumazet@google$(echo .)com \
--cc=hawk@kernel$(echo .)org \
--cc=irogers@google$(echo .)com \
--cc=jack@suse$(echo .)cz \
--cc=jgg@nvidia$(echo .)com \
--cc=jhubbard@nvidia$(echo .)com \
--cc=john.fastabend@gmail$(echo .)com \
--cc=jolsa@kernel$(echo .)org \
--cc=jonathan.lemon@gmail$(echo .)com \
--cc=kirill@shutemov$(echo .)name \
--cc=kuba@kernel$(echo .)org \
--cc=leon@kernel$(echo .)org \
--cc=linux-fsdevel@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-mm@kvack$(echo .)org \
--cc=linux-perf-users@vger$(echo .)kernel.org \
--cc=lstoakes@gmail$(echo .)com \
--cc=maciej.fijalkowski@intel$(echo .)com \
--cc=magnus.karlsson@intel$(echo .)com \
--cc=mark.rutland@arm$(echo .)com \
--cc=mingo@redhat$(echo .)com \
--cc=mjrosato@linux$(echo .)ibm.com \
--cc=mpenttil@redhat$(echo .)com \
--cc=namhyung@kernel$(echo .)org \
--cc=neescoba@cisco$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=oleg@redhat$(echo .)com \
--cc=pabeni@redhat$(echo .)com \
--cc=paulmck@kernel$(echo .)org \
--cc=peterx@redhat$(echo .)com \
--cc=peterz@infradead$(echo .)org \
--cc=richardcochran@gmail$(echo .)com \
--cc=tytso@mit$(echo .)edu \
--cc=willy@infradead$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox