From: Simon Horman <simon.horman@corigine•com>
To: Tom Rix <trix@redhat•com>
Cc: johannes@sipsolutions•net, davem@davemloft•net,
edumazet@google•com, kuba@kernel•org, pabeni@redhat•com,
nathan@kernel•org, ndesaulniers@google•com,
linux-wireless@vger•kernel.org, netdev@vger•kernel.org,
linux-kernel@vger•kernel.org, llvm@lists•linux.dev
Subject: Re: [PATCH] lib80211: remove unused variables iv32 and iv16
Date: Wed, 17 May 2023 17:11:59 +0200 [thread overview]
Message-ID: <ZGTuv7ZAMyvELMqK@corigine.com> (raw)
In-Reply-To: <20230517123310.873023-1-trix@redhat.com>
On Wed, May 17, 2023 at 08:33:10AM -0400, Tom Rix wrote:
> clang with W=1 reports
> net/wireless/lib80211_crypt_tkip.c:667:7: error: variable 'iv32'
> set but not used [-Werror,-Wunused-but-set-variable]
> u32 iv32 = tkey->tx_iv32;
> ^
> This variable not used so remove it.
> Then remove a similar iv16 variable.
> Remove the comment because the length is returned.
>
> Signed-off-by: Tom Rix <trix@redhat•com>
Reviewed-by: Simon Horman <simon.horman@corigine•com>
next prev parent reply other threads:[~2023-05-17 15:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-17 12:33 [PATCH] lib80211: remove unused variables iv32 and iv16 Tom Rix
2023-05-17 15:11 ` Simon Horman [this message]
2023-06-05 11:59 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZGTuv7ZAMyvELMqK@corigine.com \
--to=simon.horman@corigine$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=johannes@sipsolutions$(echo .)net \
--cc=kuba@kernel$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-wireless@vger$(echo .)kernel.org \
--cc=llvm@lists$(echo .)linux.dev \
--cc=nathan@kernel$(echo .)org \
--cc=ndesaulniers@google$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=trix@redhat$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox