From: Simon Horman <simon.horman@corigine•com>
To: Ido Schimmel <idosch@nvidia•com>
Cc: nbd@nbd•name, netdev@vger•kernel.org,
bridge@lists•linux-foundation.org, davem@davemloft•net,
kuba@kernel•org, pabeni@redhat•com, edumazet@google•com,
razor@blackwall•org, roopa@nvidia•com, taras.chornyi@plvision•eu,
saeedm@nvidia•com, leon@kernel•org, petrm@nvidia•com,
vladimir.oltean@nxp•com, claudiu.manoil@nxp•com,
alexandre.belloni@bootlin•com, UNGLinuxDriver@microchip•com,
jhs@mojatatu•com, xiyou.wangcong@gmail•com, jiri@resnulli•us,
taspelund@nvidia•com
Subject: Re: [PATCH net-next 3/5] flow_offload: Reject matching on layer 2 miss
Date: Fri, 19 May 2023 16:15:49 +0200 [thread overview]
Message-ID: <ZGeElc6Cd9k2URB5@corigine.com> (raw)
In-Reply-To: <ZGeDcp2A7qrKZlLk@shredder>
On Fri, May 19, 2023 at 05:10:58PM +0300, Ido Schimmel wrote:
> On Fri, May 19, 2023 at 01:33:00PM +0200, Simon Horman wrote:
> > On Thu, May 18, 2023 at 02:33:26PM +0300, Ido Schimmel wrote:
> > > Adjust drivers that support the 'FLOW_DISSECTOR_KEY_META' key to reject
> > > filters that try to match on the newly added layer 2 miss option. Add an
> > > extack message to clearly communicate the failure reason to user space.
> >
> > Hi Ido,
> >
> > FLOW_DISSECTOR_KEY_META is also used in the following.
> > Perhaps they don't need updating. But perhaps it is worth mentioning why.
>
> Good point.
>
> >
> > * drivers/net/ethernet/mediatek/mtk_ppe_offload.c
>
> This driver does not seem to do anything with this key. TBH, I'm not
> sure what is the purpose of this hunk:
>
> if (flow_rule_match_key(rule, FLOW_DISSECTOR_KEY_META)) {
> struct flow_match_meta match;
>
> flow_rule_match_meta(rule, &match);
> } else {
> return -EOPNOTSUPP;
> }
>
> Felix, can you comment?
> Original patch:
> https://lore.kernel.org/netdev/20230518113328.1952135-4-idosch@nvidia.com/
FWIIW, I agree with your analysis here.
> > * drivers/net/ethernet/netronome/nfp/flower/conntrack.c
>
> My understanding is that this code is for netfilter offload (not tc)
> which does not use the new bit. Adding a check would therefore be dead
> code. I don't mind adding a check or mentioning in the commit message
> why I didn't add one. Let me know what you prefer.
Let's go with a comment in the commit message.
Thanks.
next prev parent reply other threads:[~2023-05-19 14:16 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-18 11:33 [PATCH net-next 0/5] Add layer 2 miss indication and filtering Ido Schimmel
2023-05-18 11:33 ` [PATCH net-next 1/5] skbuff: bridge: Add layer 2 miss indication Ido Schimmel
2023-05-18 16:08 ` Nikolay Aleksandrov
2023-05-19 13:51 ` Ido Schimmel
2023-05-19 21:52 ` Jakub Kicinski
2023-05-23 8:10 ` Ido Schimmel
2023-05-23 9:04 ` Paolo Abeni
2023-05-23 11:34 ` Ido Schimmel
2023-05-23 13:03 ` Nikolay Aleksandrov
2023-05-23 20:29 ` Jakub Kicinski
2023-05-21 7:34 ` Nikolay Aleksandrov
2023-05-18 11:33 ` [PATCH net-next 2/5] net/sched: flower: Allow matching on layer 2 miss Ido Schimmel
2023-05-19 11:27 ` Simon Horman
2023-05-18 11:33 ` [PATCH net-next 3/5] flow_offload: Reject " Ido Schimmel
2023-05-19 11:33 ` Simon Horman
2023-05-19 14:10 ` Ido Schimmel
2023-05-19 14:15 ` Simon Horman [this message]
2023-05-18 11:33 ` [PATCH net-next 4/5] mlxsw: spectrum_flower: Add ability to match " Ido Schimmel
2023-05-19 11:35 ` Simon Horman
2023-05-18 11:33 ` [PATCH net-next 5/5] selftests: forwarding: Add layer 2 miss test cases Ido Schimmel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZGeElc6Cd9k2URB5@corigine.com \
--to=simon.horman@corigine$(echo .)com \
--cc=UNGLinuxDriver@microchip$(echo .)com \
--cc=alexandre.belloni@bootlin$(echo .)com \
--cc=bridge@lists$(echo .)linux-foundation.org \
--cc=claudiu.manoil@nxp$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=idosch@nvidia$(echo .)com \
--cc=jhs@mojatatu$(echo .)com \
--cc=jiri@resnulli$(echo .)us \
--cc=kuba@kernel$(echo .)org \
--cc=leon@kernel$(echo .)org \
--cc=nbd@nbd$(echo .)name \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=petrm@nvidia$(echo .)com \
--cc=razor@blackwall$(echo .)org \
--cc=roopa@nvidia$(echo .)com \
--cc=saeedm@nvidia$(echo .)com \
--cc=taras.chornyi@plvision$(echo .)eu \
--cc=taspelund@nvidia$(echo .)com \
--cc=vladimir.oltean@nxp$(echo .)com \
--cc=xiyou.wangcong@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox