Subject: Re: [RFC PATCH iwl-next 3/6] pfcp: add PFCP module

From: Simon Horman <[email-masked]>
Date: Mon, 5 Jun 2023 11:26:09 +0200

On Thu, Jun 01, 2023 at 03:19:26PM +0200, Marcin Szycik wrote:
> From: Wojciech Drewek <[email-masked]>
> 
> Packet Forwarding Control Protocol (PFCP) is a 3GPP Protocol
> used between the control plane and the user plane function.
> It is specified in TS 29.244[1].
> 
> Note that this module is not designed to support this Protocol
> in the kernel space. There is no support for parsing any PFCP messages.
> There is no API that could be used by any userspace daemon.
> Basically it does not support PFCP. This protocol is sophisticated
> and there is no need for implementing it in the kernel. The purpose
> of this module is to allow users to setup software and hardware offload
> of PFCP packets using tc tool.
> 
> When user requests to create a PFCP device, a new socket is created.
> The socket is set up with port number 8805 which is specific for
> PFCP [29.244 4.2.2]. This allow to recive PFCP request messages,
> response messages use other ports.

nit: s/recive/receive/

> 
> Note that only one PFCP netdev can be created.
> 
> Only IPv4 is supported at this time.
> 
> [1] https://portal.3gpp.org/desktopmodules/Specifications/SpecificationDetails.aspx?specificationId=3111
> 
> Signed-off-by: Wojciech Drewek <[email-masked]>
> Signed-off-by: Marcin Szycik <[email-masked]>

Reviewed-by: Simon Horman <[email-masked]>