From: Simon Horman <simon.horman@corigine•com>
To: Jamal Hadi Salim <hadi@mojatatu•com>
Cc: Jamal Hadi Salim <jhs@mojatatu•com>,
netdev@vger•kernel.org, deb.chatterjee@intel•com, tom@sipanda•io,
p4tc-discussions@netdevconf•info, Mahesh.Shirshyad@amd•com,
Vipin.Jain@amd•com, tomasz.osinski@intel•com,
xiyou.wangcong@gmail•com, davem@davemloft•net,
edumazet@google•com, kuba@kernel•org, pabeni@redhat•com,
khalidm@nvidia•com, toke@redhat•com
Subject: Re: [p4tc-discussions] Re: [PATCH RFC v2 net-next 12/28] p4tc: add header field create, get, delete, flush and dump
Date: Mon, 5 Jun 2023 17:14:21 +0200 [thread overview]
Message-ID: <ZH37za6g7UU9NPgO@corigine.com> (raw)
In-Reply-To: <CAAFAkD-=hLQzZoPtuvc0aaV8pOd8b=z2G8bYqsqM7qdKUeSB=g@mail.gmail.com>
On Mon, Jun 05, 2023 at 10:48:18AM -0400, Jamal Hadi Salim wrote:
> On Mon, Jun 5, 2023 at 6:25 AM Simon Horman via p4tc-discussions
> <p4tc-discussions@netdevconf•info> wrote:
> >
> > On Wed, May 17, 2023 at 07:02:16AM -0400, Jamal Hadi Salim wrote:
> >
> > ...
> >
> > Hi Victor, Pedro and Jamal,
> >
> > some minor feedback from my side.
> >
> > > +static int _tcf_hdrfield_fill_nlmsg(struct sk_buff *skb,
> > > + struct p4tc_hdrfield *hdrfield)
> > > +{
> > > + unsigned char *b = nlmsg_get_pos(skb);
> > > + struct p4tc_hdrfield_ty hdr_arg;
> > > + struct nlattr *nest;
> > > + /* Parser instance id + header field id */
> > > + u32 ids[2];
> > > +
> > > + ids[0] = hdrfield->parser_inst_id;
> > > + ids[1] = hdrfield->hdrfield_id;
> > > +
> > > + if (nla_put(skb, P4TC_PATH, sizeof(ids), ids))
> > > + goto out_nlmsg_trim;
> > > +
> > > + nest = nla_nest_start(skb, P4TC_PARAMS);
> > > + if (!nest)
> > > + goto out_nlmsg_trim;
> > > +
> > > + hdr_arg.datatype = hdrfield->datatype;
> > > + hdr_arg.startbit = hdrfield->startbit;
> > > + hdr_arg.endbit = hdrfield->endbit;
> >
> > There may be padding at the end of hdr_arg,
> > which is passed uninitialised to nla_put below.
>
> Yeah, same comment as the metadata case; we could add initialization
> or add PADx at the end. Or maybe there's another approach you had in
> mind.
Thanks. Yes it is the same comment, sorry for the duplicate.
No, I don't have suggestions other than the ones you have made.
next prev parent reply other threads:[~2023-06-05 15:15 UTC|newest]
Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-17 11:02 [PATCH RFC v2 net-next 01/28] net: sched: act_api: Add dynamic actions IDR Jamal Hadi Salim
2023-05-17 11:02 ` [PATCH RFC v2 net-next 02/28] net/sched: act_api: increase action kind string length Jamal Hadi Salim
2023-05-17 11:02 ` [PATCH RFC v2 net-next 03/28] net/sched: act_api: increase TCA_ID_MAX Jamal Hadi Salim
2023-06-02 14:19 ` Marcelo Ricardo Leitner
2023-06-03 13:03 ` Jamal Hadi Salim
2023-06-05 17:39 ` Jakub Kicinski
2023-06-06 17:04 ` [p4tc-discussions] " Jamal Hadi Salim
2023-06-06 17:15 ` Jakub Kicinski
2023-06-06 18:52 ` Jamal Hadi Salim
2023-05-17 11:02 ` [PATCH RFC v2 net-next 04/28] net/sched: act_api: add init_ops to struct tc_action_op Jamal Hadi Salim
2023-06-05 9:51 ` Simon Horman
2023-06-05 11:09 ` Dan Carpenter
2023-06-05 14:01 ` [p4tc-discussions] " Jamal Hadi Salim
2023-06-05 14:57 ` Dan Carpenter
2023-06-05 15:27 ` Jamal Hadi Salim
2023-05-17 11:02 ` [PATCH RFC v2 net-next 05/28] net/sched: act_api: introduce tc_lookup_action_byid() Jamal Hadi Salim
2023-06-02 19:36 ` Marcelo Ricardo Leitner
2023-06-03 13:10 ` Jamal Hadi Salim
2023-06-03 13:14 ` Jamal Hadi Salim
2023-06-05 12:08 ` Marcelo Ricardo Leitner
2023-06-05 14:55 ` [p4tc-discussions] " Jamal Hadi Salim
2023-06-05 9:55 ` Simon Horman
2023-06-05 14:17 ` [p4tc-discussions] " Jamal Hadi Salim
2023-06-05 14:31 ` Simon Horman
2023-06-05 15:04 ` Jamal Hadi Salim
2023-05-17 11:02 ` [PATCH RFC v2 net-next 06/28] net/sched: act_api: export generic tc action searcher Jamal Hadi Salim
2023-05-17 11:02 ` [PATCH RFC v2 net-next 07/28] net/sched: act_api: add struct p4tc_action_ops as a parameter to lookup callback Jamal Hadi Salim
2023-06-02 19:43 ` Marcelo Ricardo Leitner
2023-06-03 13:17 ` Jamal Hadi Salim
2023-05-17 11:02 ` [PATCH RFC v2 net-next 08/28] net: introduce rcu_replace_pointer_rtnl Jamal Hadi Salim
2023-05-17 11:02 ` [PATCH RFC v2 net-next 09/28] p4tc: add P4 data types Jamal Hadi Salim
2023-06-02 20:30 ` Marcelo Ricardo Leitner
2023-06-03 13:54 ` Jamal Hadi Salim
2023-06-05 10:08 ` Simon Horman
2023-06-05 14:26 ` [p4tc-discussions] " Jamal Hadi Salim
2023-05-17 11:02 ` [PATCH RFC v2 net-next 10/28] p4tc: add pipeline create, get, update, delete Jamal Hadi Salim
2023-06-05 10:12 ` Simon Horman
2023-06-05 14:32 ` [p4tc-discussions] " Jamal Hadi Salim
2023-06-05 14:35 ` Simon Horman
2023-06-05 15:13 ` Jamal Hadi Salim
2023-05-17 11:02 ` [PATCH RFC v2 net-next 11/28] p4tc: add metadata create, update, delete, get, flush and dump Jamal Hadi Salim
2023-05-17 11:02 ` [PATCH RFC v2 net-next 12/28] p4tc: add header field create, get, delete, " Jamal Hadi Salim
2023-06-05 10:24 ` Simon Horman
2023-06-05 14:48 ` [p4tc-discussions] " Jamal Hadi Salim
2023-06-05 15:14 ` Simon Horman [this message]
2023-06-05 15:34 ` Jamal Hadi Salim
2023-05-17 11:02 ` [PATCH RFC v2 net-next 13/28] p4tc: add action template create, update, delete, get, " Jamal Hadi Salim
2023-05-17 11:02 ` [PATCH RFC v2 net-next 14/28] p4tc: add table " Jamal Hadi Salim
2023-06-02 21:54 ` Marcelo Ricardo Leitner
2023-06-03 14:15 ` Jamal Hadi Salim
2023-05-17 11:02 ` [PATCH RFC v2 net-next 15/28] p4tc: add table entry create, update, get, delete, " Jamal Hadi Salim
2023-05-17 11:02 ` [PATCH RFC v2 net-next 16/28] p4tc: add register create, update, delete, get, " Jamal Hadi Salim
2023-05-17 11:02 ` [PATCH RFC v2 net-next 17/28] p4tc: add dynamic action commands Jamal Hadi Salim
2023-05-17 11:02 ` [PATCH RFC v2 net-next 18/28] p4tc: add P4 classifier Jamal Hadi Salim
2023-05-17 11:02 ` [PATCH RFC v2 net-next 19/28] selftests: tc-testing: add JSON introspection file directory for P4TC Jamal Hadi Salim
2023-05-17 11:02 ` [PATCH RFC v2 net-next 20/28] selftests: tc-testing: Don't assume ENVIR is declared in local config Jamal Hadi Salim
2023-06-02 22:08 ` Marcelo Ricardo Leitner
2023-06-03 14:17 ` Jamal Hadi Salim
2023-05-17 11:02 ` [PATCH RFC v2 net-next 21/28] selftests: tc-testing: add P4TC pipeline control path tdc tests Jamal Hadi Salim
2023-05-17 11:02 ` [PATCH RFC v2 net-next 22/28] selftests: tc-testing: add P4TC metadata " Jamal Hadi Salim
2023-05-17 11:02 ` [PATCH RFC v2 net-next 23/28] selftests: tc-testing: add P4TC action templates " Jamal Hadi Salim
2023-05-17 11:02 ` [PATCH RFC v2 net-next 24/28] selftests: tc-testing: add P4TC table control path " Jamal Hadi Salim
2023-05-17 11:02 ` [PATCH RFC v2 net-next 25/28] selftests: tc-testing: add P4TC table entries " Jamal Hadi Salim
2023-05-17 11:02 ` [PATCH RFC v2 net-next 26/28] selftests: tc-testing: add P4TC register " Jamal Hadi Salim
2023-05-17 11:02 ` [PATCH RFC v2 net-next 27/28] p4tc: add set of P4TC table lookup kfuncs Jamal Hadi Salim
2023-05-17 11:02 ` [PATCH RFC v2 net-next 28/28] MAINTAINERS: add p4tc entry Jamal Hadi Salim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZH37za6g7UU9NPgO@corigine.com \
--to=simon.horman@corigine$(echo .)com \
--cc=Mahesh.Shirshyad@amd$(echo .)com \
--cc=Vipin.Jain@amd$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=deb.chatterjee@intel$(echo .)com \
--cc=edumazet@google$(echo .)com \
--cc=hadi@mojatatu$(echo .)com \
--cc=jhs@mojatatu$(echo .)com \
--cc=khalidm@nvidia$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=p4tc-discussions@netdevconf$(echo .)info \
--cc=pabeni@redhat$(echo .)com \
--cc=toke@redhat$(echo .)com \
--cc=tom@sipanda$(echo .)io \
--cc=tomasz.osinski@intel$(echo .)com \
--cc=xiyou.wangcong@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox