From: Simon Horman <simon.horman@corigine•com>
To: Jakub Kicinski <kuba@kernel•org>
Cc: davem@davemloft•net, netdev@vger•kernel.org, edumazet@google•com,
pabeni@redhat•com
Subject: Re: [PATCH net-next 2/4] tools: ynl: user space helpers
Date: Mon, 5 Jun 2023 13:51:48 +0200 [thread overview]
Message-ID: <ZH3MVCH766QotC5K@corigine.com> (raw)
In-Reply-To: <20230604110034.08015f1b@kernel.org>
On Sun, Jun 04, 2023 at 11:00:34AM -0700, Jakub Kicinski wrote:
> On Sat, 3 Jun 2023 16:47:10 +0200 Simon Horman wrote:
> > > +/**
> > > + * struct ynl_error - error encountered by YNL
> > > + * Users should interact with the err member of struct ynl_sock directly.
> > > + * The main exception to that rule is ynl_sock_create().
> >
> > nit: As this is a kernel doc, maybe document the structure members here.
> >
> > > + */
> > > +struct ynl_error {
> > > + enum ynl_error_code code;
> > > + unsigned int attr_offs;
> > > + char msg[512];
> > > +};
> > > +
> > > +/**
> > > + * struct ynl_family - YNL family info
> > > + * Family description generated by codegen.
> >
> > And here.
> >
> > > + */
> > > +struct ynl_family {
> > > + const char *name;
> > > + const struct ynl_ntf_info *ntf_info;
> > > + unsigned int ntf_info_size;
> > > +};
> >
> > ...
> >
> > > +/**
> > > + * ynl_has_ntf() - check if socket has *parsed* notifications
> > > + * Note that this does not take into account notifications sitting
> > > + * in netlink socket, just the notifications which have already been
> > > + * read and parsed (e.g. during a ynl_ntf_check() call).
> >
> > And the parameter of this function here.
>
> Thanks, not sure why my brain considered this "not really kernel code
> so I don't have to obey the rules" :S I marked the innards of the
> family as private, and tossed in the other descriptions. v2 posted.
Thanks, I assumed it was something like that.
next prev parent reply other threads:[~2023-06-05 11:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-03 5:25 [PATCH net-next 0/4] tools: ynl: user space C Jakub Kicinski
2023-06-03 5:25 ` [PATCH net-next 1/4] tools: ynl-gen: clean up stray new lines at the end of reply-less requests Jakub Kicinski
2023-06-03 5:25 ` [PATCH net-next 2/4] tools: ynl: user space helpers Jakub Kicinski
2023-06-03 14:47 ` Simon Horman
2023-06-04 18:00 ` Jakub Kicinski
2023-06-05 11:51 ` Simon Horman [this message]
2023-06-03 5:25 ` [PATCH net-next 3/4] tools: ynl: support fou and netdev in C Jakub Kicinski
2023-06-03 5:25 ` [PATCH net-next 4/4] tools: ynl: add sample for netdev Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZH3MVCH766QotC5K@corigine.com \
--to=simon.horman@corigine$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox