From: Simon Horman <simon.horman@corigine•com>
To: "Drewek, Wojciech" <wojciech.drewek@intel•com>
Cc: "intel-wired-lan@lists•osuosl.org"
<intel-wired-lan@lists•osuosl.org>,
"netdev@vger•kernel.org" <netdev@vger•kernel.org>,
"Lobakin, Aleksander" <aleksander.lobakin@intel•com>,
"Ertman, David M" <david.m.ertman@intel•com>,
"michal.swiatkowski@linux•intel.com"
<michal.swiatkowski@linux•intel.com>,
"marcin.szycik@linux•intel.com" <marcin.szycik@linux•intel.com>,
"Chmielewski, Pawel" <pawel.chmielewski@intel•com>,
"Samudrala, Sridhar" <sridhar.samudrala@intel•com>,
"pmenzel@molgen•mpg.de" <pmenzel@molgen•mpg.de>,
"dan.carpenter@linaro•org" <dan.carpenter@linaro•org>
Subject: Re: [PATCH iwl-next v4 09/13] ice: Accept LAG netdevs in bridge offloads
Date: Tue, 6 Jun 2023 11:23:01 +0200 [thread overview]
Message-ID: <ZH769agjmFeTLkq9@corigine.com> (raw)
In-Reply-To: <MW4PR11MB5776E0183A1A0683D726F0EFFD4DA@MW4PR11MB5776.namprd11.prod.outlook.com>
On Mon, Jun 05, 2023 at 05:12:39PM +0000, Drewek, Wojciech wrote:
>
>
> > -----Original Message-----
> > From: Simon Horman <simon.horman@corigine•com>
> > Sent: niedziela, 4 czerwca 2023 18:07
> > To: Drewek, Wojciech <wojciech.drewek@intel•com>
> > Cc: intel-wired-lan@lists•osuosl.org; netdev@vger•kernel.org; Lobakin, Aleksander <aleksander.lobakin@intel•com>; Ertman, David M
> > <david.m.ertman@intel•com>; michal.swiatkowski@linux•intel.com; marcin.szycik@linux•intel.com; Chmielewski, Pawel
> > <pawel.chmielewski@intel•com>; Samudrala, Sridhar <sridhar.samudrala@intel•com>; pmenzel@molgen•mpg.de;
> > dan.carpenter@linaro•org
> > Subject: Re: [PATCH iwl-next v4 09/13] ice: Accept LAG netdevs in bridge offloads
> >
> > On Wed, May 24, 2023 at 02:21:17PM +0200, Wojciech Drewek wrote:
> > > Allow LAG interfaces to be used in bridge offload using
> > > netif_is_lag_master. In this case, search for ice netdev in
> > > the list of LAG's lower devices.
> >
> > Hi Wojciech,
> >
> > As this uses the first lower device found that is an ICE netdev, it is a
> > little unclear to me how this handles the (likely) case of a LAG having
> > more than one lower device, each of which are ICE netdevs belonging to the
> > same eswitch. And the perhaps less likely case where it has more than
> > once lower devices, but they don't all belong to the same ICE eswitch.
>
> The only use case here is Active-Backup bond which is send in separate patchset[1].
> 6th patch of the series[2] makes sure that that below scenarios will not happen:
> - non-ice devices
> - more than 2 devices
> So the only possible scenario would be 2 PFs of the same nic bonded together.
> In this patch we want to handle the situation when such bond is added to the bridge.
Thanks, I think that should cover the bases.
Although I haven't reviewed [2] (yet).
> Maybe we should wait with this patch until the LAG series will be accepted?
Yes, perhaps that is a good idea.
> [1] http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=355487&state=*
> [2] http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20230517230028.321350-7-david.m.ertman@intel.com/
next prev parent reply other threads:[~2023-06-06 9:23 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-24 12:21 [PATCH iwl-next v4 00/13] ice: switchdev bridge offload Wojciech Drewek
2023-05-24 12:21 ` [PATCH iwl-next v4 01/13] ice: Skip adv rules removal upon switchdev release Wojciech Drewek
2023-06-04 8:17 ` Simon Horman
2023-06-05 10:27 ` Drewek, Wojciech
2023-06-07 5:49 ` [Intel-wired-lan] " Buvaneswaran, Sujai
2023-05-24 12:21 ` [PATCH iwl-next v4 02/13] ice: Prohibit rx mode change in switchdev mode Wojciech Drewek
2023-06-04 13:59 ` Simon Horman
2023-06-12 7:30 ` [Intel-wired-lan] " Buvaneswaran, Sujai
2023-06-13 9:41 ` Drewek, Wojciech
2023-06-13 10:14 ` Buvaneswaran, Sujai
2023-06-13 10:14 ` Buvaneswaran, Sujai
2023-05-24 12:21 ` [PATCH iwl-next v4 03/13] ice: Don't tx before switchdev is fully configured Wojciech Drewek
2023-06-04 14:00 ` Simon Horman
2023-06-07 5:57 ` [Intel-wired-lan] " Buvaneswaran, Sujai
2023-05-24 12:21 ` [PATCH iwl-next v4 04/13] ice: Disable vlan pruning for uplink VSI Wojciech Drewek
2023-06-04 14:01 ` Simon Horman
2023-06-07 6:00 ` [Intel-wired-lan] " Buvaneswaran, Sujai
2023-05-24 12:21 ` [PATCH iwl-next v4 05/13] ice: Unset src prune on " Wojciech Drewek
2023-06-04 14:02 ` Simon Horman
2023-06-07 6:02 ` [Intel-wired-lan] " Buvaneswaran, Sujai
2023-05-24 12:21 ` [PATCH iwl-next v4 06/13] ice: Implement basic eswitch bridge setup Wojciech Drewek
2023-06-04 13:59 ` Simon Horman
2023-06-05 10:47 ` Drewek, Wojciech
2023-06-05 12:02 ` Simon Horman
2023-06-07 6:03 ` [Intel-wired-lan] " Buvaneswaran, Sujai
2023-05-24 12:21 ` [PATCH iwl-next v4 07/13] ice: Switchdev FDB events support Wojciech Drewek
2023-06-04 14:17 ` Simon Horman
2023-06-05 13:53 ` Drewek, Wojciech
2023-06-07 6:06 ` [Intel-wired-lan] " Buvaneswaran, Sujai
2023-05-24 12:21 ` [PATCH iwl-next v4 08/13] ice: Add guard rule when creating FDB in switchdev Wojciech Drewek
2023-06-04 16:08 ` Simon Horman
2023-06-07 6:22 ` [Intel-wired-lan] " Buvaneswaran, Sujai
2023-05-24 12:21 ` [PATCH iwl-next v4 09/13] ice: Accept LAG netdevs in bridge offloads Wojciech Drewek
2023-06-04 16:06 ` Simon Horman
2023-06-05 17:12 ` Drewek, Wojciech
2023-06-06 9:23 ` Simon Horman [this message]
2023-06-07 6:23 ` [Intel-wired-lan] " Buvaneswaran, Sujai
2023-05-24 12:21 ` [PATCH iwl-next v4 10/13] ice: Add VLAN FDB support in switchdev mode Wojciech Drewek
2023-06-04 16:37 ` Simon Horman
2023-06-05 17:45 ` Drewek, Wojciech
2023-06-07 6:25 ` [Intel-wired-lan] " Buvaneswaran, Sujai
2023-05-24 12:21 ` [PATCH iwl-next v4 11/13] ice: implement bridge port vlan Wojciech Drewek
2023-06-04 17:30 ` Simon Horman
2023-06-07 6:34 ` [Intel-wired-lan] " Buvaneswaran, Sujai
2023-05-24 12:21 ` [PATCH iwl-next v4 12/13] ice: implement static version of ageing Wojciech Drewek
2023-06-04 17:31 ` Simon Horman
2023-06-07 6:37 ` [Intel-wired-lan] " Buvaneswaran, Sujai
2023-05-24 12:21 ` [PATCH iwl-next v4 13/13] ice: add tracepoints for the switchdev bridge Wojciech Drewek
2023-06-07 6:39 ` [Intel-wired-lan] " Buvaneswaran, Sujai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZH769agjmFeTLkq9@corigine.com \
--to=simon.horman@corigine$(echo .)com \
--cc=aleksander.lobakin@intel$(echo .)com \
--cc=dan.carpenter@linaro$(echo .)org \
--cc=david.m.ertman@intel$(echo .)com \
--cc=intel-wired-lan@lists$(echo .)osuosl.org \
--cc=marcin.szycik@linux$(echo .)intel.com \
--cc=michal.swiatkowski@linux$(echo .)intel.com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pawel.chmielewski@intel$(echo .)com \
--cc=pmenzel@molgen$(echo .)mpg.de \
--cc=sridhar.samudrala@intel$(echo .)com \
--cc=wojciech.drewek@intel$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox