Subject: Re: [PATCH net-next v3 4/5] net: altera_tse: explicitly disable autoscan on the regmap-mdio bus

From: Maciej Fijalkowski <[email-masked]>
Date: Tue, 6 Jun 2023 19:20:18 +0200

On Tue, Jun 06, 2023 at 05:25:00PM +0200, Maxime Chevallier wrote:
> Set the .autoscan flag to false on the regmap-mdio bus, to avoid using a
> random uninitialized value. We don't want autoscan in this case as the
> mdio device is a PCS and not a PHY.
> 
> Fixes: db48abbaa18e ("net: ethernet: altera-tse: Convert to mdio-regmap and use PCS Lynx")
> Suggested-by: Russell King (Oracle) <[email-masked]>
> Signed-off-by: Maxime Chevallier <[email-masked]>
> ---
> V2->V3 : New patch
> 
>  drivers/net/ethernet/altera/altera_tse_main.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/ethernet/altera/altera_tse_main.c b/drivers/net/ethernet/altera/altera_tse_main.c
> index df509abcd378..b0cb94fe6247 100644
> --- a/drivers/net/ethernet/altera/altera_tse_main.c
> +++ b/drivers/net/ethernet/altera/altera_tse_main.c
> @@ -1287,6 +1287,7 @@ static int altera_tse_probe(struct platform_device *pdev)
>  	mrc.regmap = pcs_regmap;
>  	mrc.parent = &pdev->dev;
>  	mrc.valid_addr = 0x0;
> +	mrc.autoscan = false;

ah so there was uninited value on mrc :) can you please zero this out in
one of the patches?

>  
>  	/* Rx IRQ */
>  	priv->rx_irq = platform_get_irq_byname(pdev, "rx_irq");
> -- 
> 2.40.1
> 
>