From: Simon Horman <simon.horman@corigine•com>
To: Parav Pandit <parav@nvidia•com>
Cc: edumazet@google•com, davem@davemloft•net, kuba@kernel•org,
pabeni@redhat•com, dsahern@kernel•org, netdev@vger•kernel.org
Subject: Re: [PATCH net-next] net: Make gro complete function to return void
Date: Tue, 30 May 2023 09:45:09 +0200 [thread overview]
Message-ID: <ZHWphd6hL+dccyVm@corigine.com> (raw)
In-Reply-To: <20230529134430.492879-1-parav@nvidia.com>
On Mon, May 29, 2023 at 04:44:30PM +0300, Parav Pandit wrote:
> tcp_gro_complete() function only updates the skb fields related to GRO
> and it always returns zero. All the 3 drivers which are using it
> do not check for the return value either.
>
> Change it to return void instead which simplifies its callers as
> error handing becomes unnecessary.
>
> Signed-off-by: Parav Pandit <parav@nvidia•com>
Reviewed-by: Simon Horman <simon.horman@corigine•com>
next prev parent reply other threads:[~2023-05-30 7:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-29 13:44 [PATCH net-next] net: Make gro complete function to return void Parav Pandit
2023-05-30 7:45 ` Simon Horman [this message]
2023-05-30 15:25 ` David Ahern
2023-05-30 15:39 ` Parav Pandit
2023-05-30 15:51 ` David Ahern
2023-05-30 15:48 ` Eric Dumazet
2023-05-30 19:39 ` Jakub Kicinski
2023-05-30 22:36 ` David Ahern
2023-05-31 4:38 ` Eric Dumazet
2023-05-31 17:07 ` Parav Pandit
2023-05-31 9:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZHWphd6hL+dccyVm@corigine.com \
--to=simon.horman@corigine$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=dsahern@kernel$(echo .)org \
--cc=edumazet@google$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=parav@nvidia$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox