Subject: Re: [PATCH v1 net-next 05/14] udp: Remove UDP-Lite SNMP stats.

From: Simon Horman <[email-masked]>
Date: Tue, 30 May 2023 16:24:10 +0200

On Mon, May 29, 2023 at 06:03:39PM -0700, Kuniyuki Iwashima wrote:
> We stored UDP-Lite stats in udplite_statistics and udplite_stats_in6
> of struct netns_mib.
> 
> Since UDP and UDP-Lite share code, UDP_INC_STATS() always has to
> check if the socket is UDP-Lite.  However, we no longer increment
> UDP-Lite stats.
> 
> Let's remove the stats and save one protocol test.
> 
> Signed-off-by: Kuniyuki Iwashima <[email-masked]>

...

> diff --git a/include/net/udp.h b/include/net/udp.h
> index bfe62e73552a..d00509873f6f 100644
> --- a/include/net/udp.h
> +++ b/include/net/udp.h
> @@ -390,37 +390,28 @@ static inline int copy_linear_skb(struct sk_buff *skb, int len, int off,
>  }
>  
>  /*
> - * 	SNMP statistics for UDP and UDP-Lite
> + * 	SNMP statistics for UDP

nit: While we are here perhaps the space before the tab can be removed.

Otherwise, LGTM.

Reviewed-by: Simon Horman <[email-masked]>